From: David Gibson <david@gibson.dropbear.id.au>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Benjamin Herrenschmidt <benh@au.ibm.com>,
Marcelo Tossatti <mtossatti@redhat.com>,
qemu-devel@nongnu.org, anthony@codemonkey.ws,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size
Date: Mon, 27 Feb 2012 11:16:05 +1100 [thread overview]
Message-ID: <20120227001605.GD3433@truffala.fritz.box> (raw)
In-Reply-To: <CAAu8pHssMJBD16ZrbBZ=EOArLwp7d26VJw3236qCDOfv0mTsNA@mail.gmail.com>
On Sun, Feb 26, 2012 at 09:41:17PM +0000, Blue Swirl wrote:
> On Fri, Feb 24, 2012 at 00:23, David Gibson <david@gibson.dropbear.id.au> wrote:
> > From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > If the kernel page size is larger than TARGET_PAGE_SIZE, which
> > happens for example on ppc64 with kernels compiled for 64K pages,
> > the dirty tracking doesn't work.
>
> I think a better solution would be to push this to memory API and
> underlying exec.c dirty tracking so that they use the same page size
> as kernel (only in this KVM case, in general dirty tracking should
> match TARGET_PAGE_SIZE granularity).
I'm having trouble reconciling the two parts of this comment. If it
should be in terms of TARGET_PAGE_SIZE generally, why _not_ keep it
that way always, and just do a fixup when we have to send the data to
the host kernel in terms of host kernel page size?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-02-27 0:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 0:23 [Qemu-devel] [0/6] Assorted bugfixes David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 1/6] kvm: Comparison with ioctl number macros needs to be unsigned David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 2/6] slirp: Fix assertion failure on rejected DHCP requests David Gibson
2012-02-27 13:58 ` Jan Kiszka
2012-02-28 1:07 ` David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 3/6] USB OHCI bug fixes David Gibson
2012-02-27 14:13 ` Gerd Hoffmann
2012-02-28 3:09 ` David Gibson
2012-02-28 3:37 ` David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs David Gibson
2012-02-24 8:29 ` Aneesh Kumar K.V
2012-02-24 0:23 ` [Qemu-devel] [PATCH 5/6] Endian fix an assertion in usb-msd David Gibson
2012-02-24 0:23 ` [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size David Gibson
2012-02-24 1:03 ` Benjamin Herrenschmidt
2012-02-26 21:41 ` Blue Swirl
2012-02-27 0:16 ` David Gibson [this message]
2012-02-27 0:25 ` Benjamin Herrenschmidt
2012-02-27 0:36 ` Alexander Graf
2012-03-03 15:29 ` Blue Swirl
2012-02-28 12:32 ` Avi Kivity
2012-02-28 21:48 ` Benjamin Herrenschmidt
2012-03-04 10:49 ` Avi Kivity
2012-03-04 11:53 ` Benjamin Herrenschmidt
2012-03-04 12:18 ` Avi Kivity
2012-03-04 16:46 ` Andreas Färber
2012-03-04 18:46 ` Alexander Graf
2012-03-04 20:21 ` Andreas Färber
2012-03-04 20:25 ` Alexander Graf
2012-03-04 20:31 ` Andreas Färber
2012-03-04 20:59 ` Alexander Graf
2012-03-04 21:19 ` Benjamin Herrenschmidt
2012-03-04 21:45 ` Alexander Graf
2012-03-04 21:21 ` Andreas Färber
2012-03-04 21:17 ` Benjamin Herrenschmidt
2012-02-28 23:32 ` Alexander Graf
2012-02-29 0:22 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227001605.GD3433@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=benh@au.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=mtossatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.