From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/report/properties.c lib/r ...
Date: 27 Feb 2012 11:45:09 -0000 [thread overview]
Message-ID: <20120227114509.30986.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-02-27 11:45:07
Modified files:
. : WHATS_NEW
lib/report : properties.c properties.h
Log message:
Use unsigned type for bitmask
Using report_type_t for bitmask is not correct, since we have not defined types
for all bit combinations - so switching to unsigned type, since values of
report_type_t enum are unsigned.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2317&r2=1.2318
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.c.diff?cvsroot=lvm2&r1=1.33&r2=1.34
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/report/properties.h.diff?cvsroot=lvm2&r1=1.9&r2=1.10
--- LVM2/WHATS_NEW 2012/02/27 11:26:25 1.2317
+++ LVM2/WHATS_NEW 2012/02/27 11:45:05 1.2318
@@ -1,5 +1,6 @@
Version 2.02.94 -
====================================
+ Use unsigned type for bitmask instead of enum type for lvm properties.
Add missing cleanup of excl_uuid hash on some exit paths of clvmd.
Check for existance of vg_name in _format1/_pool_vg_read().
Fix missing break in _format_pvsegs (2.02.92).
--- LVM2/lib/report/properties.c 2012/01/19 15:34:33 1.33
+++ LVM2/lib/report/properties.c 2012/02/27 11:45:06 1.34
@@ -315,7 +315,7 @@
static int _get_property(const void *obj, struct lvm_property_type *prop,
- report_type_t type)
+ unsigned type)
{
struct lvm_property_type *p;
@@ -343,7 +343,7 @@
}
static int _set_property(void *obj, struct lvm_property_type *prop,
- report_type_t type)
+ unsigned type)
{
struct lvm_property_type *p;
--- LVM2/lib/report/properties.h 2010/11/17 20:11:28 1.9
+++ LVM2/lib/report/properties.h 2012/02/27 11:45:06 1.10
@@ -20,7 +20,7 @@
#include "report.h"
struct lvm_property_type {
- report_type_t type;
+ unsigned type;
const char *id;
unsigned is_settable:1;
unsigned is_string:1;
reply other threads:[~2012-02-27 11:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227114509.30986.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.