From: Jiri Bohac <jbohac@suse.cz>
To: Jiri Bohac <jbohac@suse.cz>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
netdev@vger.kernel.org
Subject: bonding: should rlb rx_hashtbl be reimplemented?
Date: Mon, 27 Feb 2012 18:46:09 +0100 [thread overview]
Message-ID: <20120227174609.GC816@midget.suse.cz> (raw)
In-Reply-To: <20120227173400.GB816@midget.suse.cz>
On Mon, Feb 27, 2012 at 06:34:00PM +0100, Jiri Bohac wrote:
> [1]: ... unless it is replaced with another value that happens to
> have the same hash -- rx_hashtbl is not a proper hash table. In
> case of a collision, the old entry is replaced by the new one.
Unrelated to this patch:
I believe that with the current implementation, if one needs to
communicate with two hosts with colliding IP addresses, RLB can't
work properly unless you renumber your network (and it will
generate an ARP storm as a side effect!).
Has anyone thought of replacing this strange hash table
implementation with a proper hash table, with colliding entries
in linked lists, some garbage collection when the hash grows too
large (configurable hash table size), etc?
Also, once the code is reworked, it could easily be made to work with
IPv6/ND in additiopn to IPv4/ARP.
I am willing to give this a try -- any thoughts?
--
Jiri Bohac <jbohac@suse.cz>
SUSE Labs, SUSE CZ
next prev parent reply other threads:[~2012-02-27 17:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 17:34 [PATCH][RFC] bonding: delete migrated IP addresses from the rlb hash table Jiri Bohac
2012-02-27 17:46 ` Jiri Bohac [this message]
2012-02-29 13:55 ` [PATCH net] bonding:update rlb entry for arp request Weiping Pan
2012-02-29 18:26 ` Jiri Bohac
2012-02-29 13:58 ` [PATCH][RFC] bonding: delete migrated IP addresses from the rlb hash table WeipingPan
2012-02-29 18:49 ` Jiri Bohac
2012-02-29 18:59 ` Jay Vosburgh
2012-03-01 2:12 ` Jay Vosburgh
2012-03-01 3:58 ` WeipingPan
2012-03-01 4:01 ` [PATCH net] delete rlb entry if ip of bonding is deleted Weiping Pan
2012-03-01 4:19 ` Jay Vosburgh
2012-03-07 16:02 ` [PATCH][RFC] bonding: delete migrated IP addresses from the rlb hash table Jiri Bohac
2012-04-20 18:56 ` Jiri Bohac
2012-04-26 20:18 ` Jay Vosburgh
2012-04-27 21:03 ` Jiri Bohac
2012-03-23 7:10 ` WeipingPan
2012-03-23 10:33 ` Jiri Bohac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227174609.GC816@midget.suse.cz \
--to=jbohac@suse.cz \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.