From: "John W. Linville" <linville@tuxdriver.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Avinash Patil <patila@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 3.3] mwifiex: remove redundant scan operation
Date: Mon, 27 Feb 2012 13:23:33 -0500 [thread overview]
Message-ID: <20120227182333.GC26664@tuxdriver.com> (raw)
In-Reply-To: <1330148136-28867-2-git-send-email-bzhao@marvell.com>
On Fri, Feb 24, 2012 at 09:35:36PM -0800, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> It should have been removed by commit "mwifiex: use cfg80211 dynamic
> scan..." (7c6fa2a843..) after adding code to avoid an extra scan
> during association because scan entries are valid for 15 seconds in
> cfg80211 stack.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
> drivers/net/wireless/mwifiex/cfg80211.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
> index e4e6d7d..7b98ce0 100644
> --- a/drivers/net/wireless/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> @@ -924,12 +924,6 @@ mwifiex_cfg80211_assoc(struct mwifiex_private *priv, size_t ssid_len, u8 *ssid,
> }
> }
> done:
> - /* Do specific SSID scanning */
> - if (mwifiex_request_scan(priv, &req_ssid)) {
> - dev_err(priv->adapter->dev, "scan error\n");
> - return -EFAULT;
> - }
> -
> /*
> * Scan entries are valid for some time (15 sec). So we can save one
> * active scan time if we just try cfg80211_get_bss first. If it fails
It seems like this could wait to be fixed in 3.4?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-02-27 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 5:35 [PATCH 3.3] mwifiex: reset encryption mode flag before association Bing Zhao
2012-02-25 5:35 ` [PATCH 3.3] mwifiex: remove redundant scan operation Bing Zhao
2012-02-27 18:23 ` John W. Linville [this message]
2012-02-27 23:47 ` Bing Zhao
2012-02-27 18:23 ` [PATCH 3.3] mwifiex: reset encryption mode flag before association John W. Linville
2012-02-27 23:44 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227182333.GC26664@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.