From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dmitry Antipov <dmitry.antipov@linaro.org>
Cc: Rusty Russell <rusty.russell@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR
Date: Tue, 28 Feb 2012 16:30:38 +0300 [thread overview]
Message-ID: <20120228133037.GG2817@mwanda> (raw)
In-Reply-To: <4F4CC19D.9040608@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Tue, Feb 28, 2012 at 03:59:25PM +0400, Dmitry Antipov wrote:
> On 02/28/2012 01:44 PM, Dan Carpenter wrote:
> >On Tue, Feb 28, 2012 at 01:33:59PM +0400, Dmitry Antipov wrote:
> >> - Fix vmap() to return ZERO_SIZE_PTR if 0 pages are requested;
> >> - fix __vmalloc_node_range() to return ZERO_SIZE_PTR if 0 bytes
> >> are requested;
> >> - fix __vunmap() to check passed pointer with ZERO_OR_NULL_PTR.
> >>
> >
> >Why?
>
> 1) it was requested by the subsystem (co?)maintainer, see http://lkml.org/lkml/2012/1/27/475;
> 2) this looks to be a convenient way to trace/debug zero-size allocation errors (although
> I don't advocate it as a best way).
Could you include that in the changelog when the final version is
ready?
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-28 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 9:33 [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR Dmitry Antipov
2012-02-28 9:33 ` Dmitry Antipov
2012-02-28 9:34 ` [PATCH 2/2] module: use ZERO_OR_NULL_PTR allocation pointer checking Dmitry Antipov
2012-02-28 9:34 ` Dmitry Antipov
2012-02-28 9:44 ` [PATCH 1/2] vmalloc: use ZERO_SIZE_PTR / ZERO_OR_NULL_PTR Dan Carpenter
2012-02-28 11:59 ` Dmitry Antipov
2012-02-28 11:59 ` Dmitry Antipov
2012-02-28 13:30 ` Dan Carpenter [this message]
2012-02-29 6:53 ` Dmitry Antipov
2012-02-29 6:53 ` Dmitry Antipov
2012-02-29 7:10 ` Dan Carpenter
2012-02-29 8:29 ` Amit Kucheria
2012-02-29 8:29 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228133037.GG2817@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.antipov@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@linaro.org \
--cc=rusty.russell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.