From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: do not try to sanity test cover letters
Date: Tue, 28 Feb 2012 15:38:37 +0000 [thread overview]
Message-ID: <20120228153836.GL8110@shadowen.org> (raw)
In-Reply-To: <1330390211.16334.24.camel@joe2Laptop>
On Mon, Feb 27, 2012 at 04:50:11PM -0800, Joe Perches wrote:
> On Mon, 2012-02-27 at 19:47 -0500, Paul Gortmaker wrote:
> > On Mon, Feb 27, 2012 at 7:36 PM, Joe Perches <joe@perches.com> wrote:
> > > On Mon, 2012-02-27 at 19:29 -0500, Paul Gortmaker wrote:
> > >> One possibly common workflow is this:
> > >>
> > >> git format-patch -o mypatches --cover-letter ^start end
> > >> ./scripts/checkpatch.pl mypatches/*
> > >
> > > I use a script for this and don't put the check
> > > in checkpatch but put the check in bash.
> >
> > Sure, and I can do the same. But my question to you is whether
> > you think the above is a common workflow, and if the false positives
> > that it generates will decrease the number of people likely to make
> > using it a part of their routine?
>
> Dunno. I generally think that tools should report
> errors when the input given them is inappropriate.
Tend to agree, the more complex we make checkpatch the more often it
will be wrong. And it is wrong enough already.
-apw
prev parent reply other threads:[~2012-02-28 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 0:29 [PATCH] checkpatch: do not try to sanity test cover letters Paul Gortmaker
2012-02-28 0:36 ` Joe Perches
2012-02-28 0:47 ` Paul Gortmaker
2012-02-28 0:50 ` Joe Perches
2012-02-28 15:38 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228153836.GL8110@shadowen.org \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.