From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx51: Fix build error due to missing include of <linux/bug.h>
Date: Wed, 29 Feb 2012 00:06:09 +0000 [thread overview]
Message-ID: <20120229000609.GG18045@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120228235244.GA3778@windriver.com>
On Tue, Feb 28, 2012 at 06:52:45PM -0500, Paul Gortmaker wrote:
> [Re: [PATCH] ARM: mx51: Fix build error due to missing include of <linux/bug.h>] On 28/02/2012 (Tue 13:21) Russell King - ARM Linux wrote:
>
> [...]
>
> > The answer is not to start scattering lots of .c files with linux/bug.h
> > includes, but to fix linux/kernel.h.
>
> Hi Russell,
>
> I understand your concerns, and had I found myself "buggering" lots
> of .c files, I would have backed away and said to myself, "OK, this
> really isn't going to work - we really can't do this."
>
> But to put some metrics to it, after building for about 10 different
> arch and all their defconfigs, I only had to change about twenty[1] of
> the approximately sixteen thousand .c files in the kernel.
I think there's more than that - I've seen two reports for other
files which have needed fixing so far, and I wouldn't be surprised if
there's more.
I guess we'll see in coming weeks how it pans out, but my gut feeling
is that this is going to cause a fair number of build problems.
prev parent reply other threads:[~2012-02-29 0:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 12:11 [PATCH] ARM: mx51: Fix build error due to missing include of <linux/bug.h> Fabio Estevam
2012-02-28 12:53 ` Russell King - ARM Linux
2012-02-28 13:03 ` Fabio Estevam
2012-02-28 13:21 ` Russell King - ARM Linux
2012-02-28 13:25 ` Fabio Estevam
2012-02-28 23:52 ` Paul Gortmaker
2012-02-29 0:06 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229000609.GG18045@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.