All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: Warning from unlock_new_inode
Date: Wed, 29 Feb 2012 11:53:51 +1100	[thread overview]
Message-ID: <20120229005351.GV3592@dastard> (raw)
In-Reply-To: <20120228083444.GB22995@infradead.org>

On Tue, Feb 28, 2012 at 03:34:44AM -0500, Christoph Hellwig wrote:
> On Wed, Feb 22, 2012 at 11:01:37PM +0100, Jan Kara wrote:
> >   Hello,
> > 
> >   while running fsstress on XFS partition with 3.3-rc4 kernel + my freeze
> > fixes (they do not touch anything relevant AFAICT) I've got the following
> > warning:
> 
> That's stressing including freezes or without?  Do you have a better
> description of te workload?
> 
> Either way it's an odd one, I can't see any obvious way how this would
> happen.

FWIW, I'm trying to track down exactly the same warning on a RHEL6.2
kernel being triggered by NFS filehandle lookup. The problem is
being being reproduced reliably by a well known NFS benchmark, but
this gives more a bit more information on where a race condition in
the inode lookup may exist.

That is, the only common element here in these two lookup paths is
that they are the only two calls to xfs_iget() with
XFS_IGET_UNTRUSTED set in the flags. I doubt this is a coincidence.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-02-29  0:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 22:01 Warning from unlock_new_inode Jan Kara
2012-02-28  8:34 ` Christoph Hellwig
2012-02-28 10:11   ` Jan Kara
2012-02-29  0:53   ` Dave Chinner [this message]
2012-02-29  1:49     ` Dave Chinner
2012-02-29  9:03       ` Christoph Hellwig
2012-02-29 10:24       ` Jan Kara
2012-03-01  3:03       ` Ben Myers
2012-03-01  3:58         ` Dave Chinner
2012-03-01  5:09       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120229005351.GV3592@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.