From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Manoj Iyer <manoj.iyer@canonical.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook
Date: Tue, 28 Feb 2012 17:03:11 -0800 [thread overview]
Message-ID: <20120229010311.GA11492@core.coreip.homeip.net> (raw)
In-Reply-To: <20120229004604.GB21093@kroah.com>
On Tue, Feb 28, 2012 at 04:46:04PM -0800, Greg KH wrote:
> On Tue, Feb 28, 2012 at 06:36:10PM -0600, Manoj Iyer wrote:
> > HP ProBooks do not send a key release for brightness keys, as a
> > result, brightness does not move up/down when the brightness key
> > is held down. This quirk makes the brightness keys on HP ProBooks
> > typematic.
> >
> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> > ---
> > drivers/input/keyboard/atkbd.c | 16 ++++++++++++++++
> > 1 files changed, 16 insertions(+), 0 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>
Also, this should be handled from userspace by having usev write to
/sys/bus/serio/devices/serioX/force_release attribute on affected boxes.
--
Dmitry
next prev parent reply other threads:[~2012-02-29 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 0:36 [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook Manoj Iyer
2012-02-29 0:36 ` Manoj Iyer
2012-02-29 0:46 ` Greg KH
2012-02-29 1:03 ` Dmitry Torokhov [this message]
2012-02-29 5:56 ` Manoj Iyer
2012-02-29 6:17 ` Dmitry Torokhov
2012-02-29 6:57 ` Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229010311.GA11492@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manoj.iyer@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.