From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h
Date: Tue, 28 Feb 2012 17:49:08 -0800 [thread overview]
Message-ID: <20120229014906.GL18901@atomide.com> (raw)
In-Reply-To: <20120229014719.GK18901@atomide.com>
* Tony Lindgren <tony@atomide.com> [120228 17:15]:
> * Rob Herring <robherring2@gmail.com> [120226 19:15]:
> > On 02/24/2012 12:22 PM, Tony Lindgren wrote:
> > > * Tony Lindgren <tony@atomide.com> [120223 15:36]:
> > >> * Rob Herring <robherring2@gmail.com> [120221 17:53]:
> > >>> On 02/21/2012 05:40 PM, Tony Lindgren wrote:
> > >>>> +
> > >>>> +/*
> > >>>> + * NOTE: Please use ioremap + __raw_read/write where possible instead of these
> > >>>> + */
> > >>>> +
> > >>>> +extern u8 omap_readb(u32 pa);
> > >>>> +extern u16 omap_readw(u32 pa);
> > >>>> +extern u32 omap_readl(u32 pa);
> > >>>> +extern void omap_writeb(u8 v, u32 pa);
> > >>>> +extern void omap_writew(u16 v, u32 pa);
> > >>>> +extern void omap_writel(u32 v, u32 pa);
> > >>>
> > >>> These can't be moved to common.h like omap2?
> > >>
> > >> Not for omap1 currently because a bunch of legacy drivers are
> > >> using them :(
> > >
> > > Looks like we can have them in mach-omap1/include/mach/hardware.h.
> > >
> > > Eventually the SoC specific hardware.h files could be renamed to
> > > just something like omap1.h, omap2plus.h and so. And then they
> > > could be included in the common hardware.h.
> > >
> > > Updated patch below, now io.h for both omap1 and omap2+ are
> > > minimized, and turns out only minimal driver changes were needed.
> > >
> >
> > Looks good to me. Do you have a branch for this that I can base on?
>
> Yes it's now in iomap branch that merged into my cleanup branch that
> I'll ask Arnd and Olof to pull tomorrow.
>
> So take your pick out of the following two:
>
> 1. iomap branch based on v3.3-rc4 that you probably want to use
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap iomap
Correction: #1 above is based on v3.3-rc3, not -rc4.
> 2. cleanup branch based on RMK's commit 61b80086a525c8a6081257ae40da5dee2bcaee16
> (Merge branch 'entry-macro-cleanup' of git://sources.calxeda.com/kernel/linux into for-armsoc)
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap cleanup
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h
Date: Tue, 28 Feb 2012 17:49:08 -0800 [thread overview]
Message-ID: <20120229014906.GL18901@atomide.com> (raw)
In-Reply-To: <20120229014719.GK18901@atomide.com>
* Tony Lindgren <tony@atomide.com> [120228 17:15]:
> * Rob Herring <robherring2@gmail.com> [120226 19:15]:
> > On 02/24/2012 12:22 PM, Tony Lindgren wrote:
> > > * Tony Lindgren <tony@atomide.com> [120223 15:36]:
> > >> * Rob Herring <robherring2@gmail.com> [120221 17:53]:
> > >>> On 02/21/2012 05:40 PM, Tony Lindgren wrote:
> > >>>> +
> > >>>> +/*
> > >>>> + * NOTE: Please use ioremap + __raw_read/write where possible instead of these
> > >>>> + */
> > >>>> +
> > >>>> +extern u8 omap_readb(u32 pa);
> > >>>> +extern u16 omap_readw(u32 pa);
> > >>>> +extern u32 omap_readl(u32 pa);
> > >>>> +extern void omap_writeb(u8 v, u32 pa);
> > >>>> +extern void omap_writew(u16 v, u32 pa);
> > >>>> +extern void omap_writel(u32 v, u32 pa);
> > >>>
> > >>> These can't be moved to common.h like omap2?
> > >>
> > >> Not for omap1 currently because a bunch of legacy drivers are
> > >> using them :(
> > >
> > > Looks like we can have them in mach-omap1/include/mach/hardware.h.
> > >
> > > Eventually the SoC specific hardware.h files could be renamed to
> > > just something like omap1.h, omap2plus.h and so. And then they
> > > could be included in the common hardware.h.
> > >
> > > Updated patch below, now io.h for both omap1 and omap2+ are
> > > minimized, and turns out only minimal driver changes were needed.
> > >
> >
> > Looks good to me. Do you have a branch for this that I can base on?
>
> Yes it's now in iomap branch that merged into my cleanup branch that
> I'll ask Arnd and Olof to pull tomorrow.
>
> So take your pick out of the following two:
>
> 1. iomap branch based on v3.3-rc4 that you probably want to use
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap iomap
Correction: #1 above is based on v3.3-rc3, not -rc4.
> 2. cleanup branch based on RMK's commit 61b80086a525c8a6081257ae40da5dee2bcaee16
> (Merge branch 'entry-macro-cleanup' of git://sources.calxeda.com/kernel/linux into for-armsoc)
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap cleanup
Regards,
Tony
next prev parent reply other threads:[~2012-02-29 1:49 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 23:40 [PATCH 0/8] Split omap plat/io.h into local iomap.h files Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 1/8] ARM: OMAP2+: Move DISPC L3 firewall to happen in omap_display_init() Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-22 8:09 ` Tomi Valkeinen
2012-02-22 8:09 ` Tomi Valkeinen
2012-02-22 8:09 ` Tomi Valkeinen
2012-02-22 19:05 ` Tony Lindgren
2012-02-22 19:05 ` Tony Lindgren
2012-02-22 19:05 ` Tony Lindgren
2012-02-22 22:17 ` Tony Lindgren
2012-02-22 22:17 ` Tony Lindgren
2012-02-22 22:17 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 2/8] ARM: OMAP2+: Move SDRC related functions from io.h into local common.h Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 3/8] ARM: OMAP: Move omap_init_consistent_dma_size() to " Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 4/8] ARM: OMAP1: Move 16xx GPIO system clock to platform init code Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-23 23:42 ` Tony Lindgren
2012-02-23 23:42 ` Tony Lindgren
2012-03-12 17:30 ` Grant Likely
2012-03-12 17:30 ` Grant Likely
2012-03-12 18:05 ` Tony Lindgren
2012-03-12 18:05 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 5/8] ARM: OMAP1: Move most of plat/io.h into local iomap.h Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-23 23:44 ` Tony Lindgren
2012-02-23 23:44 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 6/8] ARM: OMAP2+: " Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-23 23:46 ` Tony Lindgren
2012-02-23 23:46 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-22 2:24 ` Rob Herring
2012-02-22 2:24 ` Rob Herring
2012-02-24 0:06 ` Tony Lindgren
2012-02-24 0:06 ` Tony Lindgren
2012-02-24 18:22 ` Tony Lindgren
2012-02-24 18:22 ` Tony Lindgren
2012-02-27 3:47 ` Rob Herring
2012-02-27 3:47 ` Rob Herring
2012-02-29 1:47 ` Tony Lindgren
2012-02-29 1:47 ` Tony Lindgren
2012-02-29 1:49 ` Tony Lindgren [this message]
2012-02-29 1:49 ` Tony Lindgren
2012-02-29 23:59 ` Rob Herring
2012-02-29 23:59 ` Rob Herring
2012-03-01 0:11 ` Russell King - ARM Linux
2012-03-01 0:11 ` Russell King - ARM Linux
2012-03-01 0:39 ` Tony Lindgren
2012-03-01 0:39 ` Tony Lindgren
2012-03-01 1:03 ` Tony Lindgren
2012-03-01 1:03 ` Tony Lindgren
2012-03-01 3:34 ` Rob Herring
2012-03-01 3:34 ` Rob Herring
2012-03-01 3:46 ` Tony Lindgren
2012-03-01 3:46 ` Tony Lindgren
2012-03-01 3:53 ` Rob Herring
2012-03-01 3:53 ` Rob Herring
2012-03-01 4:54 ` Tony Lindgren
2012-03-01 4:54 ` Tony Lindgren
2012-02-21 23:40 ` [PATCH 8/8] ARM: OMAP2+: Limit omap_read/write usage to legacy USB drivers Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-21 23:40 ` Tony Lindgren
2012-02-22 8:14 ` Tomi Valkeinen
2012-02-22 8:14 ` Tomi Valkeinen
2012-02-22 8:14 ` Tomi Valkeinen
2012-02-22 18:57 ` Tony Lindgren
2012-02-22 18:57 ` Tony Lindgren
2012-02-22 18:57 ` Tony Lindgren
2012-02-22 22:44 ` Tony Lindgren
2012-02-22 22:44 ` Tony Lindgren
2012-02-22 22:44 ` Tony Lindgren
2012-02-24 18:25 ` Tony Lindgren
2012-02-24 18:25 ` Tony Lindgren
2012-02-24 18:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229014906.GL18901@atomide.com \
--to=tony@atomide.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=robherring2@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.