From: Dan Carpenter <dan.carpenter@oracle.com>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
linux-kernel@vger.kernel.org,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 1/2] staging: zcache: fix length type mismatch
Date: Wed, 29 Feb 2012 09:22:20 +0300 [thread overview]
Message-ID: <20120229062220.GA22598@mwanda> (raw)
In-Reply-To: <1330466497-24361-1-git-send-email-sjenning@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Tue, Feb 28, 2012 at 04:01:37PM -0600, Seth Jennings wrote:
> This fixes a type mismatch in the compression code where
> a size_t pointer was cast to a unsigned int pointer. On
> little endian archs, there is no issue. However on big
> endian archs, the value is incorrect, taking the high
> order bits and truncating the lower order bits.
I would think this would be a problem on any 64bit machine not just
big endian ones. Since clen is half uninitialized we would likely
hit the clen > zbud_max_buddy_size() test.
Anyway the patch is right.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-29 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 22:01 [PATCH 1/2] staging: zcache: fix length type mismatch Seth Jennings
2012-02-29 6:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229062220.GA22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cascardo@holoscopio.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.