All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PULL] Memory core space reduction
Date: Wed, 29 Feb 2012 13:25:52 +0200	[thread overview]
Message-ID: <20120229112552.GB5233@redhat.com> (raw)
In-Reply-To: <4F4E03BE.0@redhat.com>

On Wed, Feb 29, 2012 at 12:53:50PM +0200, Avi Kivity wrote:
> On 02/29/2012 12:23 PM, Michael S. Tsirkin wrote:
> > On Wed, Feb 29, 2012 at 12:09:14PM +0200, Avi Kivity wrote:
> > > On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote:
> > > >
> > > > What I did, to allow bisect, is rebase Avi's patches on top
> > > > of my bridge implementation, then run qemu with a bridge.
> > > > bridge without Avi's patches at least starts booting, with
> > > > Avi's patches crashes before guest start.
> > > >
> > > > If you want to play with that, take it from branch bisectme
> > > > on my qemu tree on github.
> > > >
> > > 
> > > How do you reproduce it?
> > > 
> > > I tried
> > > 
> > >    qemu-system-x86_64 -device pci-bridge,chassis_nr=23
> > > 
> > > but that boots.
> >
> > It could be that you need more devices.  This is my command line:
> > qemu-system-x86_64  -m 1G -drive file=/home/mst/rhel6.qcow2 -netdev
> > user,id=bar -net nic,netdev=bar,model=e1000,macaddr=52:54:00:12:34:57
> > -redir tcp:8022::22 -device pci-bridge,id=bog,chassis_nr=1 -netdev
> > tap,id=foo,ifname=msttap0,script=/home/mst/ifup,downscript=no,vhost=on
> > -nographic 
> >
> 
> Boots too, even after supplying a peer to foo.
> 
> I did get an abort with -enable-kvm, but that looks like the old issue,
> no?  Looking into it.
> 
> Suggest a valgrind run.

It does not crash under valgrind :)
But valgrid did show some info:

==9202== Invalid write of size 8
==9202==    at 0x2F313D: portio_list_add_1 (ioport.c:379)
==9202==    by 0x224473: parallel_isa_initfn (parallel.c:505)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x3357F0: pc_basic_device_init (pc.h:53)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202==    by 0x24EFE7: main (vl.c:3397)
==9202==  Address 0x27b202b8 is 0 bytes after a block of size 8 alloc'd
==9202==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==9202==    by 0x24D4C5: malloc_and_trace (vl.c:2156)
==9202==    by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x2F2FBC: portio_list_init (ioport.c:331)
==9202==    by 0x21A545: isa_register_portio_list (isa-bus.c:109)
==9202==    by 0x224473: parallel_isa_initfn (parallel.c:505)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x3357F0: pc_basic_device_init (pc.h:53)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202==    by 0x24EFE7: main (vl.c:3397)
==9202== 
==9202== Invalid write of size 8
==9202==    at 0x2F312F: portio_list_add_1 (ioport.c:378)
==9202==    by 0x2064FA: isabus_fdc_init1 (fdc.c:1893)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x3358ED: pc_basic_device_init (fdc.h:25)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202==    by 0x24EFE7: main (vl.c:3397)
==9202==  Address 0x28f54d20 is 0 bytes after a block of size 16 alloc'd
==9202==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==9202==    by 0x24D4C5: malloc_and_trace (vl.c:2156)
==9202==    by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x2F2FAB: portio_list_init (ioport.c:330)
==9202==    by 0x21A545: isa_register_portio_list (isa-bus.c:109)
==9202==    by 0x2064FA: isabus_fdc_init1 (fdc.c:1893)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x3358ED: pc_basic_device_init (fdc.h:25)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202== 
==9202== Invalid write of size 8
==9202==    at 0x2F313D: portio_list_add_1 (ioport.c:379)
==9202==    by 0x2064FA: isabus_fdc_init1 (fdc.c:1893)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x3358ED: pc_basic_device_init (fdc.h:25)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202==    by 0x24EFE7: main (vl.c:3397)
==9202==  Address 0x27b2ec78 is 8 bytes after a block of size 16 alloc'd
==9202==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==9202==    by 0x24D4C5: malloc_and_trace (vl.c:2156)
==9202==    by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x2F2FBC: portio_list_init (ioport.c:331)
==9202==    by 0x21A545: isa_register_portio_list (isa-bus.c:109)
==9202==    by 0x2064FA: isabus_fdc_init1 (fdc.c:1893)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x3358ED: pc_basic_device_init (fdc.h:25)
==9202==    by 0x337DB2: pc_init1 (pc_piix.c:240)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202== 
==9202== Invalid write of size 8
==9202==    at 0x2F313D: portio_list_add_1 (ioport.c:379)
==9202==    by 0x2169EF: pci_piix_ide_initfn (piix.c:137)
==9202==    by 0x2269DD: pci_qdev_init (pci.c:1492)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x225DD7: pci_create_simple_multifunction (pci.c:1552)
==9202==    by 0x216C7E: pci_piix3_ide_init (piix.c:224)
==9202==    by 0x338036: pc_init1 (pc_piix.c:257)
==9202==    by 0x3383E7: pc_init_pci (pc_piix.c:319)
==9202==    by 0x24EFE7: main (vl.c:3397)
==9202==  Address 0x28fc30a8 is 0 bytes after a block of size 8 alloc'd
==9202==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
==9202==    by 0x24D4C5: malloc_and_trace (vl.c:2156)
==9202==    by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5)
==9202==    by 0x2F2FBC: portio_list_init (ioport.c:331)
==9202==    by 0x21A545: isa_register_portio_list (isa-bus.c:109)
==9202==    by 0x2169EF: pci_piix_ide_initfn (piix.c:137)
==9202==    by 0x2269DD: pci_qdev_init (pci.c:1492)
==9202==    by 0x274839: qdev_init (qdev.c:150)
==9202==    by 0x27491C: qdev_init_nofail (qdev.c:243)
==9202==    by 0x225DD7: pci_create_simple_multifunction (pci.c:1552)
==9202==    by 0x216C7E: pci_piix3_ide_init (piix.c:224)
==9202== 
=

Investigating.

> -- 
> error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-02-29 11:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 12:25 [Qemu-devel] [PULL] Memory core space reduction Avi Kivity
2012-02-28 12:26 ` Avi Kivity
2012-02-28 17:59 ` Michael S. Tsirkin
2012-02-28 18:13   ` Anthony Liguori
2012-02-28 18:15     ` Avi Kivity
2012-02-28 18:31       ` Anthony Liguori
2012-02-28 18:56       ` Anthony Liguori
2012-02-28 19:14       ` Anthony Liguori
2012-02-28 19:17         ` Avi Kivity
2012-02-28 19:20           ` Anthony Liguori
2012-02-28 22:58             ` Michael S. Tsirkin
2012-02-29 10:09               ` Avi Kivity
2012-02-29 10:23                 ` Michael S. Tsirkin
2012-02-29 10:53                   ` Avi Kivity
2012-02-29 11:25                     ` Michael S. Tsirkin [this message]
2012-02-29 11:31                       ` Avi Kivity
2012-02-29 11:45                         ` Avi Kivity
2012-02-29 14:15                           ` Michael S. Tsirkin
2012-02-29 11:27                     ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2012-02-28 12:24 Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120229112552.GB5233@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.