From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH (BUGFIX)] gitweb: Handle invalid regexp in regexp search
Date: Wed, 29 Feb 2012 16:56:35 +0100 [thread overview]
Message-ID: <201202291656.36222.jnareb@gmail.com> (raw)
In-Reply-To: <7vwr76yc6w.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > When using regexp search ('sr' parameter / $search_use_regexp variable
> > is true), check first that regexp is valid.
>
> Thanks.
>
> How old is this bug? Should it go to older maitenance tracks like 1.7.6?
>From what I examined this bug is from the very beginning when gitweb
started to distinguish regexp search and fixed string search in
0e55991 (gitweb: Clearly distinguish regexp / exact match searches, 2008-02-26)
It was present in 1.5.5 (including beginnings of match highlighting, which
trigger this bug).
This bug was present so long without detection because circumstances must
be quite specific: you have to select regexp search, and to provide invalid
regexp. If you know what regexp is, you probably write correct ones...
but there always room for mistake.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2012-02-29 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 18:41 [PATCH (BUGFIX)] gitweb: Handle invalid regexp in regexp search Jakub Narebski
2012-02-28 19:45 ` Junio C Hamano
2012-02-29 15:56 ` Jakub Narebski [this message]
2012-03-02 19:44 ` Ramsay Jones
2012-03-02 22:34 ` [PATCH (BUGFIX)] gitweb: Fix fixed string (non-regexp) project search Jakub Narebski
2012-03-03 0:08 ` Junio C Hamano
2012-03-03 10:55 ` Jakub Narebski
2012-03-04 9:35 ` [PATCH (for maint)] " Jakub Narebski
2012-03-05 5:16 ` Junio C Hamano
2012-03-05 8:59 ` Jakub Narebski
2012-03-05 17:01 ` Junio C Hamano
2012-03-05 23:27 ` Junio C Hamano
2012-03-06 11:59 ` Jakub Narebski
2012-03-04 18:00 ` [PATCH (BUGFIX)] " Jakub Narebski
2012-03-04 23:08 ` Junio C Hamano
2012-03-05 9:03 ` Jakub Narebski
2012-03-05 19:06 ` Ramsay Jones
2012-03-06 12:40 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202291656.36222.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.