From: Evgeniy Polyakov <zbr@ioremap.net>
To: Renata Sayakhova <rsayakhova@gmail.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH] DS2781 Maxim Stand-Alone Fuel Gauge battery and w1 slave drivers
Date: Wed, 29 Feb 2012 21:52:59 +0300 [thread overview]
Message-ID: <20120229185259.GC32077@ioremap.net> (raw)
In-Reply-To: <1330523933-32344-2-git-send-email-rsayakhova@gmail.com>
Hi Renata
On Wed, Feb 29, 2012 at 02:58:53PM +0100, Renata Sayakhova (rsayakhova@gmail.com) wrote:
>
> Signed-off-by: Renata Sayakhova <rsayakhova@gmail.com>
Patch looks good except this weird function
> +static inline int ds2781_battery_io(struct ds2781_device_info *dev_info,
> + char *buf, int addr, size_t count, int io)
> +{
> + if (dev_info->mutex_holder == current)
> + return w1_ds2781_io_nolock(dev_info->w1_dev, buf, addr,
> + count, io);
> + else
> + return w1_ds2781_io(dev_info->w1_dev, buf, addr, count, io);
> +}
Who in the stack can run away holding mutex?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2012-02-29 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 13:58 [PATCH 0001] DS2781 Maxim Stand-Alone Fuel Gauge battery and w1 slave drivers Renata Sayakhova
2012-02-29 13:58 ` [PATCH] " Renata Sayakhova
2012-02-29 18:52 ` Evgeniy Polyakov [this message]
[not found] ` <CAO0_4pY_MXgx1gFRK9ino0P9RAO3e3E00PFCJvjpq2A-6Oz=1Q@mail.gmail.com>
2012-02-29 23:24 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229185259.GC32077@ioremap.net \
--to=zbr@ioremap.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rsayakhova@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.