From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Forshee Subject: Re: [PATCH v2] platform/x86: Add driver for Apple gmux device Date: Wed, 29 Feb 2012 16:56:50 -0600 Message-ID: <20120229225650.GD20565@ubuntu-macmini> References: <1329424465-1211-1-git-send-email-seth.forshee@canonical.com> <1329921457-26887-1-git-send-email-seth.forshee@canonical.com> <20120229175327.GA20565@ubuntu-macmini> <20120229195042.GB20565@ubuntu-macmini> <20120229220809.GC20565@ubuntu-macmini> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:48383 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756841Ab2B2W4x (ORCPT ); Wed, 29 Feb 2012 17:56:53 -0500 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Grant Likely Cc: Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Feb 29, 2012 at 04:32:28PM -0600, Grant Likely wrote: > On Wed, Feb 29, 2012 at 4:08 PM, Seth Forshee > wrote: > > On Wed, Feb 29, 2012 at 03:23:20PM -0600, Grant Likely wrote: > >> On Wed, Feb 29, 2012 at 1:50 PM, Seth Forshee > >> wrote: > >> > On Wed, Feb 29, 2012 at 12:43:23PM -0600, Grant Likely wrote: > >> >> On Wed, Feb 29, 2012 at 11:53 AM, Seth Forshee > >> >> wrote: > >> >> > On Wed, Feb 29, 2012 at 11:46:39AM -0600, Grant Likely wrote: > >> >> >> On Wed, Feb 22, 2012 at 8:37 AM, Seth Forshee > >> >> >> wrote: > >> >> >> > Apple laptops with hybrid graphics have a device named gmu= x that > >> >> >> > controls the muxing of the LVDS panel between the GPUs as = well as screen > >> >> >> > brightness. This driver adds support for the gmux device. = Only backlight > >> >> >> > control is supported initially. > >> >> >> > > >> >> >> > Signed-off-by: Seth Forshee > >> >> >> > >> >> >> Works for me. > >> >> >> > >> >> >> Tested-by: Grant Likely > >> >> >> > >> >> >> Now I just need to figure out how to get the desktop backlig= ht widget > >> >> >> to use gmux_backlight instead of acpi_video0... > >> >> > > >> >> > The easy way is to pass acpi_backlight=3Dvendor to the kernel= , then you > >> >> > won't have acpi_vidoe0. > >> >> > >> >> That did it, thanks. =C2=A0I'm assume something is in the works= to set it > >> >> up automatically? > >> > > >> > Not that I'm aware of. A number machines have this problem, that= the > >> > standard ACPI backlight interfaces are implemented but don't wor= k. This > >> > generally isn't detectable in software; with the Apples at least > >> > everything looks like it's working except that the brightness do= esn't > >> > change (but not all Apple laptops are affected, so qurking based= on > >> > manufacturer wouldn't work). All we're left with is DMI quirking= , which > >> > isn't practical. Maybe we could add something so a platform driv= er can > >> > tell acpi_video that it knows the ACPI backlight doesn't work, b= ut I > >> > think on some platforms that still is going to be based off of D= MI > >> > information. > >> > >> blacklisting based on specific product name (ie. MacBookPro8,*) or > >> machine model is probably the best. =C2=A0It wouldn't be the first > >> blacklist in the linux kernel. > > > > I think the blacklist would have to be against specific product nam= es. > > For example, the MacBook Pro 8,1 has a working acpi_video backlight= and > > no gmux_backlight, the 8,2 has both but only gmux_backlight works, = and I > > suspect the 8,3 is the same as the 8,2. >=20 > I have the 8,3, and my testing confirms that. >=20 > > We'd probably end up with an > > entry in the blacklist for every single model whose acpi_video back= light > > doesn't work, adding entries for each new generation of MacBooks. > > > > And if we start blacklisting Macs we'd have start doing it for othe= r > > machines too, I guess. From what I've seen, open-ended blacklists l= ike > > this get nacked pretty consistently nowadays. >=20 > An alternative would be to blacklist or disable acpi0_backlight when > the apple-gmux driver loads. I don't know how acceptable that is, bu= t > I also don't have much sympathy for nacking blacklists if there isn't > a viable alternative. Yes, that's one idea I was thinking about. For all the machines I've been able to get tested, if the gmux is present then it can control the backlight and acpi_video cannot, so that approach is reasonable for Macs. There are quite a few machines in this situation though, and whatever solution is arrived at should be flexible enough to work beyond just Macs. I'll try to find some time soon to explore this further and see i= f I can come up with something. Seth