From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Liam Girdwood <lrg@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Grazvydas Ignotas <notasas@gmail.com>
Subject: Re: [PATCH v2 08/10] ASoC: omap-mcbsp: Cleanup of module probe/remove code
Date: Wed, 29 Feb 2012 23:33:05 +0000 [thread overview]
Message-ID: <20120229233305.GH8295@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1330414820-4641-9-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Tue, Feb 28, 2012 at 09:40:18AM +0200, Peter Ujfalusi wrote:
> Use devm_* where it is possible to save on cleanup path.
> Start merging the two mcbsp file content.
> Move pm_runtime_enable/disable calls to ASoC probe, remove from module
> probe/remove time.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
though I don't see any reason not to enable pm_runtime in the device
model probe, that way I'd expect you can save a little power on unused
McBSP ports.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-29 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 7:40 [PATCH v2 00/10] OMAP/ASoC: Move and merge McBSP driver under ASoC Peter Ujfalusi
2012-02-28 7:40 ` [PATCH v2 01/10] ARM: OMAP: mcbsp: Convert core driver to proper platform driver Peter Ujfalusi
2012-02-28 19:32 ` Jarkko Nikula
2012-02-28 7:40 ` [PATCH v2 02/10] OMAP: mcbsp: Move core driver under sound/soc/omap Peter Ujfalusi
2012-02-28 7:40 ` [PATCH v2 03/10] ASoC: OMAP: McBSP: Consolidate plat/mcbsp.h content Peter Ujfalusi
2012-02-29 23:30 ` Mark Brown
2012-02-28 7:40 ` [PATCH v2 04/10] ASoC: omap-mcbsp: Create a single driver for McBSP Peter Ujfalusi
2012-02-29 23:31 ` Mark Brown
2012-02-28 7:40 ` [PATCH v2 05/10] ARM: OMAP: Do not register omap-mcbsp-dai device Peter Ujfalusi
2012-02-28 7:40 ` [PATCH v2 06/10] ASoC: OMAP: mcbsp.h: Clean up bit definitions Peter Ujfalusi
2012-02-28 7:40 ` [PATCH v2 07/10] ASoC: OMAP McBSP: Remove redundant accessors Peter Ujfalusi
2012-02-28 7:40 ` [PATCH v2 08/10] ASoC: omap-mcbsp: Cleanup of module probe/remove code Peter Ujfalusi
2012-02-29 23:33 ` Mark Brown [this message]
2012-02-28 7:40 ` [PATCH v2 09/10] ASoC: omap-mcbsp: Merge the omap_mcbsp_data into omap_mcbsp structure Peter Ujfalusi
2012-02-29 23:33 ` Mark Brown
2012-02-28 7:40 ` [PATCH v2 10/10] ASoC: omap-mcbsp: Simplify DMA configuration Peter Ujfalusi
2012-02-29 23:34 ` Mark Brown
2012-02-28 10:49 ` [PATCH v2 00/10] OMAP/ASoC: Move and merge McBSP driver under ASoC Mark Brown
2012-03-02 14:37 ` Peter Ujfalusi
2012-02-28 19:32 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229233305.GH8295@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.