From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-pci@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] PCI / PM: Disable wakeup during shutdown for devices not enabled to wake up
Date: Fri, 2 Mar 2012 10:04:50 -0800 [thread overview]
Message-ID: <20120302100450.5752ff2f@jbarnes-desktop> (raw)
In-Reply-To: <20120302093712.6cd513a3@jbarnes-desktop>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Fri, 2 Mar 2012 09:37:12 -0800
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > The device driver can monitor .runtime_{suspend / resume} activity
> > and take appropriate action in .shutdown(). Sameer Nanda has sent
> > such a patch (see below). I am not sure this is the adequate fix:
> > 1. the driver ought essentially to perform the hardware part of a
> > .runtime_resume() on its own behalf. Mildly engaging.
> > 2. by the same line as above, could it make more sense to call
> > pm_runtime_resume() in driver/base/core.c::device_shutdown ?
>
> I thought there would be a more elegant way of increasing the device
> use count on entering .shutdown, either from the wifi core or at the
> driver level, so you don't have to track things with a separate flag.
>
> Rafael?
s/wifi/net of course.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-02 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 23:50 [PATCH] PCI / PM: Disable wakeup during shutdown for devices not enabled to wake up Rafael J. Wysocki
2012-02-10 20:34 ` Jesse Barnes
2012-02-10 22:40 ` Rafael J. Wysocki
2012-02-10 23:51 ` Jesse Barnes
2012-03-02 14:44 ` Francois Romieu
2012-03-02 17:37 ` Jesse Barnes
2012-03-02 18:04 ` Jesse Barnes [this message]
2012-03-02 18:08 ` Alan Stern
2012-03-02 20:49 ` Rafael J. Wysocki
2012-03-02 20:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302100450.5752ff2f@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.