From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 2 Mar 2012 20:02:59 +0000 Subject: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt. In-Reply-To: <20120302195710.GP11986@titan.lakedaemon.net> References: <201203021832.34901.arnd@arndb.de> <20120302195710.GP11986@titan.lakedaemon.net> Message-ID: <201203022003.08756.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 02 March 2012, Jason wrote: > On Fri, Mar 02, 2012 at 06:32:33PM +0000, Arnd Bergmann wrote: > > > As I commented before, I think the best approach would be to > > provide a hardcoded resource for the device in the legacy case > > and just use platform_get_resource() to get the resource > > and ioremap it in either case. > > Sorry, my denseness got in the way. When you said hardcoded, I thought > you meant #define TIMER_VIRT_BASE . Using TIMER_VIRT_BASE wouldn't be all that wrong either, but I think it's better to use the same code path in both ways. Using a resource also has the nice side-effect of allowing us to build a multiplatform kernel for anything that uses orion-wdt but has different constants for TIMER_VIRT_BASE. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 5/5 v2] ARM: kirkwood: convert orion-wdt to fdt. Date: Fri, 2 Mar 2012 20:02:59 +0000 Message-ID: <201203022003.08756.arnd@arndb.de> References: <201203021832.34901.arnd@arndb.de> <20120302195710.GP11986@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120302195710.GP11986-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jason Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Friday 02 March 2012, Jason wrote: > On Fri, Mar 02, 2012 at 06:32:33PM +0000, Arnd Bergmann wrote: > > > As I commented before, I think the best approach would be to > > provide a hardcoded resource for the device in the legacy case > > and just use platform_get_resource() to get the resource > > and ioremap it in either case. > > Sorry, my denseness got in the way. When you said hardcoded, I thought > you meant #define TIMER_VIRT_BASE . Using TIMER_VIRT_BASE wouldn't be all that wrong either, but I think it's better to use the same code path in both ways. Using a resource also has the nice side-effect of allowing us to build a multiplatform kernel for anything that uses orion-wdt but has different constants for TIMER_VIRT_BASE. Arnd