From: Paul Brook <paul@codesourcery.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Bernhard M. Wiedemann" <bwiedemann@suse.de>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: guard mmap_next_start from specific maps
Date: Sun, 4 Mar 2012 00:43:09 +0000 [thread overview]
Message-ID: <201203040043.09582.paul@codesourcery.com> (raw)
In-Reply-To: <1330816936-21772-1-git-send-email-agraf@suse.de>
> If the guest process tells us to map at a specific address, we shouldn't
> increase the "last automatic mapping ended here" variable.
That sounds reasonable, in fact I'd go further. Tests on an x86-linux machine
(both 32-bit and 64-bit userspace) show that if the requested address is not
available then it is completely ignored.
> + if (start == mmap_next_start && addr >= TASK_UNMAPPED_BASE) {
> + mmap_next_start = addr;
Code does not match description.
Paul
prev parent reply other threads:[~2012-03-04 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 23:22 [Qemu-devel] [PATCH] linux-user: guard mmap_next_start from specific maps Alexander Graf
2012-03-04 0:43 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203040043.09582.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=bwiedemann@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.