From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3zXh-0001je-Kf for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:43:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3zXg-0000mB-1G for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:43:17 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:60274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3zXf-0000m7-RQ for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:43:15 -0500 From: Paul Brook Date: Sun, 4 Mar 2012 00:43:09 +0000 References: <1330816936-21772-1-git-send-email-agraf@suse.de> In-Reply-To: <1330816936-21772-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201203040043.09582.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH] linux-user: guard mmap_next_start from specific maps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "Bernhard M. Wiedemann" , Riku Voipio , qemu-devel qemu-devel , Peter Maydell > If the guest process tells us to map at a specific address, we shouldn't > increase the "last automatic mapping ended here" variable. That sounds reasonable, in fact I'd go further. Tests on an x86-linux machine (both 32-bit and 64-bit userspace) show that if the requested address is not available then it is completely ignored. > + if (start == mmap_next_start && addr >= TASK_UNMAPPED_BASE) { > + mmap_next_start = addr; Code does not match description. Paul