From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45945)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S4BNH-0002Es-3H
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 08:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S4BNF-0006GU-Fh
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 08:21:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S4BNF-0006GB-7S
	for qemu-devel@nongnu.org; Sun, 04 Mar 2012 08:21:17 -0500
Date: Sun, 4 Mar 2012 15:21:17 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120304132116.GA12047@redhat.com>
References: <20120304094614.GA8158@redhat.com>
	<CAAu8pHuyD_KmZGV8GF1AJhaurdATcC3s24RTnxWa7iCCszcbDw@mail.gmail.com>
	<4F535FD4.2000905@redhat.com>
	<CAAu8pHs4hmQebYkZLz8owozJRUfMohD0SLPq-FJBixXLnZCfwA@mail.gmail.com>
	<4F5362FD.5060305@redhat.com>
	<CAAu8pHvSbp_vGFic782dS9+U6UfLpgx0iDiXQCJns1DsZ3j1pw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAAu8pHvSbp_vGFic782dS9+U6UfLpgx0iDiXQCJns1DsZ3j1pw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Avi Kivity <avi@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On Sun, Mar 04, 2012 at 12:46:23PM +0000, Blue Swirl wrote:
> On Sun, Mar 4, 2012 at 12:41, Avi Kivity <avi@redhat.com> wrote:
> > On 03/04/2012 02:38 PM, Blue Swirl wrote:
> >> >>
> >> >> This unassigned memory exception is triggered because CMD646 IDE =
I/O
> >> >> registers are not accessible:
> >> >>
> >> >> (qemu) info pci
> >> >> =A0 Bus =A00, device =A0 5, function 0:
> >> >> =A0 =A0 IDE controller: PCI device 1095:0646
> >> >> =A0 =A0 =A0 IRQ 1.
> >> >> =A0 =A0 =A0 BAR0: I/O at 0xffffffffffffffff [0x0006].
> >> >> =A0 =A0 =A0 BAR1: I/O at 0xffffffffffffffff [0x0002].
> >> >> =A0 =A0 =A0 BAR2: I/O at 0xffffffffffffffff [0x0006].
> >> >> =A0 =A0 =A0 BAR3: I/O at 0xffffffffffffffff [0x0002].
> >> >> =A0 =A0 =A0 BAR4: I/O at 0xffffffffffffffff [0x000e].
> >> >> =A0 =A0 =A0 id ""
> >> >
> >> > The BARs are not initialized, so they aren't accessible.
> >> >
> >> > But perhaps the dump was not taken at the point of failure, can yo=
u
> >> > provide a relevant dump if so?
> >>
> >> No, this is after failure.
> >
> > I don't see why the guest expects the BARs to work then.
>=20
> OpenBIOS could initialize them before this commit, now it obviously
> can't (or initializes the bridges incorrectly).

I traced all config reads and writes to the bridge
and there's no difference I can see
between before and after this commit.

I think there's some other bug, tweaking this
specific bit just happens to trigger it.

> Maybe also the devices should be moved behind the bridges, that's
> where they really should be.
>=20
> >
> > --
> > error compiling committee.c: too many arguments to function
> >