From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW libdm/libdm-deptree.c
Date: 4 Mar 2012 17:36:25 -0000 [thread overview]
Message-ID: <20120304173625.20524.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2012-03-04 17:36:24
Modified files:
. : WHATS_NEW
libdm : libdm-deptree.c
Log message:
Return success for deactivation of thin pool
if the thin_check fail on thin pool - still return successful deactivation,
since lvremove would currently fail.
TODO: find some way to not run check with lvremove.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2339&r2=1.2340
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/libdm/libdm-deptree.c.diff?cvsroot=lvm2&r1=1.162&r2=1.163
--- LVM2/WHATS_NEW 2012/03/03 18:32:53 1.2339
+++ LVM2/WHATS_NEW 2012/03/04 17:36:23 1.2340
@@ -1,5 +1,6 @@
Version 2.02.95 -
================================
+ Deactivation of failed thin check on thin pool returns success.
Scan all devices for lvmetad if 'pvscan --cache' used without device list.
Populate lvmcache from lvmetad before displaying PVs in pvscan. (2.02.94)
Suppress incorrect -n pvscan warning now always displayed. (2.02.94)
--- LVM2/libdm/libdm-deptree.c 2012/03/04 16:05:42 1.162
+++ LVM2/libdm/libdm-deptree.c 2012/03/04 17:36:24 1.163
@@ -1591,7 +1591,10 @@
if (child->callback &&
!child->callback(child, DM_NODE_CALLBACK_DEACTIVATED,
child->callback_data))
- r = 0; // FIXME: _node_clear_table() without callback ?
+ stack;
+ // FIXME: We need to let lvremove pass,
+ // so for now deactivation ignores check result
+ //r = 0; // FIXME: _node_clear_table() without callback ?
if (dm_tree_node_num_children(child, 0) &&
!_dm_tree_deactivate_children(child, uuid_prefix, uuid_prefix_len, level + 1))
next reply other threads:[~2012-03-04 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 17:36 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-30 9:24 LVM2 ./WHATS_NEW libdm/libdm-deptree.c zkabelac
2010-11-23 18:29 zkabelac
2010-06-21 8:54 prajnoha
2010-06-21 9:32 ` Zdenek Kabelac
2010-05-21 12:30 zkabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120304173625.20524.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.