From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig'
Date: Mon, 5 Mar 2012 10:37:17 +0100 [thread overview]
Message-ID: <20120305103717.5125e3c4@skate> (raw)
In-Reply-To: <1330866196-5360-2-git-send-email-arnout@mind.be>
Le Sun, 4 Mar 2012 14:03:15 +0100,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :
> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> So that this works:
>
> % make defconfig DEFCONFIG=~/busybox-defconfig
>
> Right now we have to do:
>
> % cp ~/busybox-defconfig configs/busybox_defconfig
> % make busybox_defconfig
>
> That would dirty the buildroot tree and requires it to be writable.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Please change "busybox" to "buildroot" in the commit log. Otherwise,
it's confusing since one might think you're talking about the Busybox
configuration file.
> + @$(COMMON_CONFIG_ENV) $< --defconfig$(patsubst %,=%,$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
I'm not sure I understand why patsubst is used here. Something like:
$(if $(BR2_DEFCONFIG),=$(BR2_DEFCONFIG))
would look more natural to me. Unless I'm missing something, of course.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-03-05 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 13:03 [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-04 13:03 ` [Buildroot] [PATCH v2 2/3] config: make it possible to specify which config file to use for 'make defconfig' Arnout Vandecappelle
2012-03-05 9:37 ` Thomas Petazzoni [this message]
2012-03-05 9:58 ` Luca Ceresoli
2012-03-05 21:58 ` Felipe Contreras
2012-03-04 13:03 ` [Buildroot] [PATCH v2 3/3] Add test infrastructure Arnout Vandecappelle
2012-03-04 13:22 ` Arnout Vandecappelle
2012-03-05 9:39 ` Thomas Petazzoni
2012-03-06 7:09 ` Arnout Vandecappelle
2012-03-04 13:05 ` [Buildroot] [PATCH v2 1/3] Add target to print buildroot version Arnout Vandecappelle
2012-03-05 9:29 ` Luca Ceresoli
2012-03-06 7:11 ` Arnout Vandecappelle
2012-03-05 9:34 ` Thomas Petazzoni
2012-03-05 9:33 ` Thomas Petazzoni
2012-03-05 9:57 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305103717.5125e3c4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.