From: Ted Ts'o <tytso@mit.edu>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [patch] ext4: clean up the flags passed to __blockdev_direct_IO for extent-based files
Date: Mon, 5 Mar 2012 10:25:09 -0500 [thread overview]
Message-ID: <20120305152509.GA21356@thunk.org> (raw)
In-Reply-To: <x49zkc7c36m.fsf@segfault.boston.devel.redhat.com>
On Fri, Feb 24, 2012 at 04:49:21PM -0500, Jeff Moyer wrote:
> Hi,
>
> For extent-based files, you can perform DIO to holes, as mentioned in
> the comments in ext4_ext_direct_IO. However, that function passes
> DIO_SKIP_HOLES to __blockdev_direct_IO, which is *really* confusing to
> the uninitiated reader. The key, here, is that the get_block function
> passed in, ext4_get_block_write, completely ignores the create flag that
> is passed to it (the create flag is passed in from the direct I/O code,
> which uses the DIO_SKIP_HOLES flag to determine whether or not it should
> be cleared).
>
> This is a long-winded way of saying that the DIO_SKIP_HOLES flag is
> ultimately ignored. So, in the interest of preserving sanity, I propose
> the following patch.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2012-03-05 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 21:49 [patch] ext4: clean up the flags passed to __blockdev_direct_IO for extent-based files Jeff Moyer
2012-02-24 21:52 ` Eric Sandeen
2012-03-05 15:25 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305152509.GA21356@thunk.org \
--to=tytso@mit.edu \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.