From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 5 Mar 2012 20:16:26 +0000 Subject: [PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt In-Reply-To: <20120305191546.GK5050@titan.lakedaemon.net> References: <20120305191546.GK5050@titan.lakedaemon.net> Message-ID: <201203052016.26949.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 05 March 2012, Jason wrote: > > > > The clock frequency part being hardcoded to 200000 in the common .dtsi > > file looks wrong. The clock may differ, and it used to (and should) be > > probed at run time, please see kirkwood_find_tclk(). > > So, should I EXPORT_SYMBOL_GPL(kirkwood_find_tclk); and have each driver > call it? If the drivers want to use it, I think it has to be orion_find_tclk for drivers that are shared between multiple plat-orion platforms. > One alternate idea I had was to have kirkwood-dreamplug.dts root hold > > tclk: clock-frequency = <200000000>; > > and then have the drivers ask for it. afaict, tclk is constant per > board. > > I'm fine with either way, but I'd rather have it in the dt. IMHO it's best to leave any such hacks out of the device tree for now, until we have the proper clk bindings in place for kirkwood, and then we can just use those. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt Date: Mon, 5 Mar 2012 20:16:26 +0000 Message-ID: <201203052016.26949.arnd@arndb.de> References: <20120305191546.GK5050@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120305191546.GK5050-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jason Cc: Nicolas Pitre , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday 05 March 2012, Jason wrote: > > > > The clock frequency part being hardcoded to 200000 in the common .dtsi > > file looks wrong. The clock may differ, and it used to (and should) be > > probed at run time, please see kirkwood_find_tclk(). > > So, should I EXPORT_SYMBOL_GPL(kirkwood_find_tclk); and have each driver > call it? If the drivers want to use it, I think it has to be orion_find_tclk for drivers that are shared between multiple plat-orion platforms. > One alternate idea I had was to have kirkwood-dreamplug.dts root hold > > tclk: clock-frequency = <200000000>; > > and then have the drivers ask for it. afaict, tclk is constant per > board. > > I'm fine with either way, but I'd rather have it in the dt. IMHO it's best to leave any such hacks out of the device tree for now, until we have the proper clk bindings in place for kirkwood, and then we can just use those. Arnd