Re: [v9 PATCH 2/3] NETFILTER module xt_hmark, new target for HASH based fwmark

[Hans Schillstrom <hans@schillstrom.com>]

On Monday, March 05, 2012 17:50:24 Pablo Neira Ayuso wrote:
> On Mon, Mar 05, 2012 at 11:48:16AM +0100, Jan Engelhardt wrote:
> > 
> > On Monday 2012-03-05 11:09, Hans Schillstrom wrote:
> > >> > diff --git a/net/netfilter/Makefile b/net/netfilter/Makefile
> > >> > index 40f4c3d..21bc5e8 100644
> > >> > --- a/net/netfilter/Makefile
> > >> > +++ b/net/netfilter/Makefile
> > >> > @@ -57,6 +57,7 @@ obj-$(CONFIG_NETFILTER_XT_TARGET_CONNSECMARK) += xt_CONNSECMARK.o
> > >> >  obj-$(CONFIG_NETFILTER_XT_TARGET_CT) += xt_CT.o
> > >> >  obj-$(CONFIG_NETFILTER_XT_TARGET_DSCP) += xt_DSCP.o
> > >> >  obj-$(CONFIG_NETFILTER_XT_TARGET_HL) += xt_HL.o
> > >> > +obj-$(CONFIG_NETFILTER_XT_TARGET_HMARK) += xt_hmark.o
> > >> 
> > >> Netfilter's naming policy requires that targets are in upper case.
> > >
> > >I asked netfilter team about that, and got the answer
> > >that it should be lower case for new modules.
> > >Have that been changed ?
> > 
> > The name of the file is pretty much irrelevant (because loading
> > solely depends on MODULE_ALIAS), so I share that only lowercase
> > should be used for new things. It's not that the linux kernel would
> > currently be storable on a case-insensitive filesystem, but that does
> > not mean we can't latently work towards it.
> 
> Sorry, I want to stick to that naming policy.
> 
OK, renaming in progress ..

/Hans