From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Bart De Schuymer <bdschuym@pandora.be>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v2] bridge: netfilter: don't call iptables on vlan packets if sysctl is off
Date: Mon, 5 Mar 2012 23:35:58 +0100 [thread overview]
Message-ID: <20120305223558.GA30357@1984> (raw)
In-Reply-To: <20120305210235.GF11311@Chamillionaire.breakpoint.cc>
On Mon, Mar 05, 2012 at 10:02:35PM +0100, Florian Westphal wrote:
> Bart De Schuymer <bdschuym@pandora.be> wrote:
> > Op 5/03/2012 12:13, Florian Westphal schreef:
> > > When net.bridge.bridge-nf-filter-vlan-tagged is 0 (default), vlan packets
> > > arriving should not be sent to ip(6)tables by bridge netfilter.
> >
> > > +#define IS_ARP(skb) \
> > > + (!vlan_tx_tag_present(skb)&& skb->protocol == htons(ETH_P_ARP))
> > > +
> >
> > I could nitpick on the lack of a space before the && (it's also in other
> > places in your patch). Is that intentional?
>
> No; but I can't see where this is coming from. The space shows up
> at the right place here. It also seems to be correct in marc.info
> archives.
>
> Pablo, please yell at me if the patch doesn't work for you.
Interesting, that space doesn't show up here.
Applied, thanks guys.
prev parent reply other threads:[~2012-03-05 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 11:13 [PATCH v2] bridge: netfilter: don't call iptables on vlan packets if sysctl is off Florian Westphal
2012-03-05 17:02 ` Bart De Schuymer
2012-03-05 21:02 ` Florian Westphal
2012-03-05 22:35 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305223558.GA30357@1984 \
--to=pablo@netfilter.org \
--cc=bdschuym@pandora.be \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.