All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Allison Henderson <achender@linux.vnet.ibm.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/1] ext4: Remove empty index blocks when punching holes
Date: Mon, 5 Mar 2012 18:54:30 -0500	[thread overview]
Message-ID: <20120305235430.GA12796@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1202290916590.4926@dhcp-27-109.brq.redhat.com>

On Wed, Feb 29, 2012 at 09:18:54AM +0100, Lukas Czerner wrote:
> > 
> > Alrighty then, sounds good.  This patch seemed to correct the loop discard bug
> > we saw earlier for me.  So please make sure you have some similar fix in your
> > new patch.  Basically we had some extra index blocks hanging around when the
> > depth was greater than one, so the patch just adds some code to free up those
> > index blocks in the path if they are empty.  Hope this helps!  Thx!  :)
> 
> Actually I started to modifying the punch hole code in order to find
> that bug and this problem does go away with my pathes. I'll CC
> you on the patches when I send them out.

OK, so my understanding is that Lukas's patches solve the same problem
as Allison's, and those are the patches I should review and integrate?

   	      	  	    		- Ted

  reply	other threads:[~2012-03-05 23:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29  7:37 [PATCH 1/1] ext4: Remove empty index blocks when punching holes Allison Henderson
2012-02-29  7:44 ` Lukas Czerner
2012-02-29  8:15   ` Allison Henderson
2012-02-29  8:18     ` Lukas Czerner
2012-03-05 23:54       ` Ted Ts'o [this message]
2012-03-06  7:11         ` Lukas Czerner
2012-03-06 16:44           ` Ted Ts'o
     [not found]             ` <4F565962.1020604@linux.vnet.ibm.com>
2012-03-06 18:42               ` Allison Henderson
2012-03-07  7:05                 ` Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120305235430.GA12796@thunk.org \
    --to=tytso@mit.edu \
    --cc=achender@linux.vnet.ibm.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.