From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601Ab2CFF3U (ORCPT ); Tue, 6 Mar 2012 00:29:20 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40397 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901Ab2CFF3S (ORCPT ); Tue, 6 Mar 2012 00:29:18 -0500 X-Sasl-enc: HkK5OMHiUaPplN+Gk2rURLDtRs7b5YJrbIgQ8UXbuDL1 1331011757 Date: Mon, 5 Mar 2012 21:28:49 -0800 From: Greg Kroah-Hartman To: Grant Likely Cc: linux-kernel@vger.kernel.org, Tony Lindgren , Mark Brown , Arnd Bergmann , Dilan Lee , Manjunath GKondaiah , Alan Stern Subject: Re: [PATCH] drivercore: Add driver probe deferral mechanism Message-ID: <20120306052849.GC19454@kroah.com> References: <1330962461-9061-1-git-send-email-grant.likely@secretlab.ca> <20120305214747.GA9425@kroah.com> <20120305221528.GA11935@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 05, 2012 at 05:08:30PM -0700, Grant Likely wrote: > On Mon, Mar 5, 2012 at 3:15 PM, Greg Kroah-Hartman > wrote: > > On Mon, Mar 05, 2012 at 03:09:27PM -0700, Grant Likely wrote: > >> On Mon, Mar 5, 2012 at 2:47 PM, Greg Kroah-Hartman > >> wrote: > >> > On Mon, Mar 05, 2012 at 08:47:41AM -0700, Grant Likely wrote: > >> >> --- a/include/linux/device.h > >> >> +++ b/include/linux/device.h > >> >> @@ -587,6 +587,10 @@ struct device_dma_parameters { > >> >>   * @mutex:   Mutex to synchronize calls to its driver. > >> >>   * @bus:     Type of bus device is on. > >> >>   * @driver:  Which driver has allocated this > >> >> + * @deferred_probe: entry in deferred_probe_list which is used to retry the > >> >> + *           binding of drivers which were unable to get all the resources > >> >> + *           needed by the device; typically because it depends on another > >> >> + *           driver getting probed first. > >> >>   * @platform_data: Platform data specific to the device. > >> >>   *           Example: For devices on custom boards, as typical of embedded > >> >>   *           and SOC based hardware, Linux often uses platform_data to point > >> >> @@ -646,6 +650,7 @@ struct device { > >> >>       struct bus_type *bus;           /* type of bus device is on */ > >> >>       struct device_driver *driver;   /* which driver has allocated this > >> >>                                          device */ > >> >> +     struct list_head        deferred_probe; > >> >>       void            *platform_data; /* Platform specific data, device > >> >>                                          core doesn't touch it */ > >> >>       struct dev_pm_info      power; > >> > > >> > This can go into the "struct device_private" structure instead, right? > >> > That would be better to ensure that no non-driver-core code ever touches > >> > this thing. > >> > >> I don't see any reason why not.  I'll make the change and repost. > > > > If you are going to repost, care to fix up your multi-line comment > > blocks to follow the "standard" way of doing it? > > > > That saves me doing the follow-on patch to do it myself :) > > Yeah, I can do that. > > Actually, if you're okay with this version other than the private data > change, could you pick up this version (it's actually received > testing) and I'll provide follow up patches to fix up the issues > pointed out by you and Arnd. Yes, I can, and I might as well fix up the private thing myself and the comments when I do that, I'll cc: you on that. I have a flight tomorrow so I might get the chance to do it then. thanks, greg k-h