Re: [Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On Tue, Mar 06, 2012 at 04:28:20PM +0100, Michal Privoznik wrote:
> On 29.02.2012 17:02, Michal Privoznik wrote:
> > This command returns an array of:
> > 
> >  [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ]
> > 
> > for each interface in the system.
> > Currently, only IPv4 and IPv6 are supported.
> > 
> > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > ---
> > diff to v5:
> > -another change of command
> > diff to v4:
> > -change return type
> > 
> > diff to v3:
> > -use ctpop32() instead of separate count_one_bits()
> > 
> > diff to v2:
> > -Properly set IP addr family for IPv6
> > 
> > diff to v1:
> > -move from guest-getip to guest-network-info
> > -replace black boxed algorithm for population count
> > -several coding styles improvements
> > 
> >  qapi-schema-guest.json |   59 ++++++++++++++++
> >  qga/commands-posix.c   |  181 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  qga/commands-win32.c   |    6 ++
> >  3 files changed, 246 insertions(+), 0 deletions(-)
> > 
> 
> ping?

Looks good other than a s/get-network-interfaces/network-get-interfaces,
but I can fix that up. Have it queued for testing, should get to it today.

> 
>