From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH 20/20] ASoC: fsl: add imx-sgtl5000 machine driver
Date: Tue, 6 Mar 2012 20:11:53 +0000 [thread overview]
Message-ID: <20120306201153.GF19635@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F565528.1090505@wwwdotorg.org>
[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]
On Tue, Mar 06, 2012 at 11:19:20AM -0700, Stephen Warren wrote:
> > In this case (and probably in the i.MX case, at a guess the structure is
> > the same) I'd just have the DAI drivers kick off registration of the
> > ASoC DMA stuff, it's all part of the ASoC driver for the hardware really.
>
> How would that work when there are multiple DAIs, e.g. on a system with
> 2 I2S and 1 SPDIF DAI and they all want to register the PCM driver? I
> guess I could just add some utility function in the PCM driver file to
> ensure that the platform device only gets created once, and probably
> would also need to refcount it for when the DAIs get unloaded etc.
You could just create a DMA device per DAI since it's just a wrapper,
you shouldn't even need to allocate a new struct device but just use the
DAI device when registering the ASoC DMA driver.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 20/20] ASoC: fsl: add imx-sgtl5000 machine driver
Date: Tue, 6 Mar 2012 20:11:53 +0000 [thread overview]
Message-ID: <20120306201153.GF19635@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F565528.1090505@wwwdotorg.org>
On Tue, Mar 06, 2012 at 11:19:20AM -0700, Stephen Warren wrote:
> > In this case (and probably in the i.MX case, at a guess the structure is
> > the same) I'd just have the DAI drivers kick off registration of the
> > ASoC DMA stuff, it's all part of the ASoC driver for the hardware really.
>
> How would that work when there are multiple DAIs, e.g. on a system with
> 2 I2S and 1 SPDIF DAI and they all want to register the PCM driver? I
> guess I could just add some utility function in the PCM driver file to
> ensure that the platform device only gets created once, and probably
> would also need to refcount it for when the DAIs get unloaded etc.
You could just create a DMA device per DAI since it's just a wrapper,
you shouldn't even need to allocate a new struct device but just use the
DAI device when registering the ASoC DMA driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120306/6289f0aa/attachment.sig>
next prev parent reply other threads:[~2012-03-06 20:11 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 15:19 [PATCH 00/20] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 01/20] ASoC: imx: move eukrea audmux call into ASoC machine driver Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 02/20] ASoC: imx: move phycore " Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 03/20] ARM: imx: merge audmux-v1 and audmux-v2 Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-05 0:22 ` Tabi Timur-B04825
2012-03-05 0:22 ` Tabi Timur-B04825
2012-03-05 7:33 ` Shawn Guo
2012-03-05 7:33 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 04/20] ARM: imx: convert audmux to a platform driver Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-04 19:00 ` Sascha Hauer
2012-03-04 19:00 ` Sascha Hauer
2012-03-05 7:35 ` Shawn Guo
2012-03-05 7:35 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 05/20] ASoC: imx: move audmux driver into sound/soc/imx Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 06/20] ASoC: imx: rename audmux prefix mxc to imx Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 07/20] ASoC: imx: move SND_SOC_AC97_BUS selection down to machine driver Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-04 13:34 ` Mark Brown
2012-03-04 13:34 ` Mark Brown
2012-03-03 15:19 ` [PATCH 08/20] ASoC: imx: initialize dma_params burstsize just in imx-ssi Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-04 13:26 ` Mark Brown
2012-03-04 13:26 ` Mark Brown
2012-03-03 15:19 ` [PATCH 09/20] ASoC: imx: separate imx-pcm bits from imx-ssi driver Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-04 13:41 ` Mark Brown
2012-03-04 13:41 ` Mark Brown
2012-03-03 15:19 ` [PATCH 10/20] ASoC: imx: add an explicit Kconfig option for " Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 11/20] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 12/20] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 13/20] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 14/20] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 15/20] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-04 23:13 ` Tabi Timur-B04825
2012-03-04 23:13 ` Tabi Timur-B04825
2012-03-04 23:28 ` Russell King - ARM Linux
2012-03-04 23:28 ` Russell King - ARM Linux
2012-03-04 23:32 ` Tabi Timur-B04825
2012-03-04 23:32 ` Tabi Timur-B04825
2012-03-05 0:04 ` Russell King - ARM Linux
2012-03-05 0:04 ` Russell King - ARM Linux
2012-03-05 0:13 ` Tabi Timur-B04825
2012-03-05 0:13 ` Tabi Timur-B04825
2012-03-05 0:26 ` Mark Brown
2012-03-05 0:26 ` Mark Brown
2012-03-06 10:40 ` Russell King - ARM Linux
2012-03-06 10:40 ` Russell King - ARM Linux
2012-03-06 12:06 ` Mark Brown
2012-03-06 12:06 ` Mark Brown
2012-03-06 12:25 ` Russell King - ARM Linux
2012-03-06 12:25 ` Russell King - ARM Linux
2012-03-06 12:33 ` Mark Brown
2012-03-06 12:33 ` Mark Brown
2012-03-06 13:02 ` Tabi Timur-B04825
2012-03-06 13:02 ` Tabi Timur-B04825
2012-03-06 13:03 ` Mark Brown
2012-03-06 13:03 ` Mark Brown
2012-03-06 13:26 ` Takashi Iwai
2012-03-06 13:26 ` [alsa-devel] " Takashi Iwai
2012-03-06 13:38 ` Mark Brown
2012-03-06 13:38 ` [alsa-devel] " Mark Brown
2012-03-06 13:46 ` Takashi Iwai
2012-03-06 13:46 ` [alsa-devel] " Takashi Iwai
2012-03-06 13:52 ` Russell King - ARM Linux
2012-03-06 13:52 ` [alsa-devel] " Russell King - ARM Linux
2012-03-06 16:54 ` Mark Brown
2012-03-06 16:54 ` [alsa-devel] " Mark Brown
2012-03-06 13:46 ` Russell King - ARM Linux
2012-03-06 13:46 ` Russell King - ARM Linux
2012-03-06 10:39 ` Russell King - ARM Linux
2012-03-06 10:39 ` Russell King - ARM Linux
2012-03-05 7:39 ` Shawn Guo
2012-03-05 7:39 ` Shawn Guo
2012-03-05 12:28 ` Tabi Timur-B04825
2012-03-05 12:28 ` Tabi Timur-B04825
2012-03-05 13:40 ` Shawn Guo
2012-03-05 13:40 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 16/20] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 17/20] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:19 ` [PATCH 18/20] ASoC: fsl: add dt support for imx-audmux Shawn Guo
2012-03-03 15:19 ` Shawn Guo
2012-03-03 15:20 ` [PATCH 19/20] ASoC: rename sgtl5000 device tree binding document Shawn Guo
2012-03-03 15:20 ` Shawn Guo
2012-03-04 13:39 ` Mark Brown
2012-03-04 13:39 ` Mark Brown
2012-03-03 15:20 ` [PATCH 20/20] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-03 15:20 ` Shawn Guo
2012-03-04 13:38 ` Mark Brown
2012-03-04 13:38 ` Mark Brown
2012-03-05 8:06 ` Shawn Guo
2012-03-05 8:06 ` Shawn Guo
2012-03-05 11:56 ` Mark Brown
2012-03-05 11:56 ` Mark Brown
2012-03-05 13:07 ` Shawn Guo
2012-03-05 13:07 ` Shawn Guo
2012-03-05 13:13 ` Mark Brown
2012-03-05 13:13 ` Mark Brown
2012-03-05 16:55 ` Stephen Warren
2012-03-05 16:55 ` [alsa-devel] " Stephen Warren
2012-03-05 17:03 ` Mark Brown
2012-03-05 17:03 ` [alsa-devel] " Mark Brown
2012-03-06 18:19 ` Stephen Warren
2012-03-06 18:19 ` [alsa-devel] " Stephen Warren
2012-03-06 20:11 ` Mark Brown [this message]
2012-03-06 20:11 ` Mark Brown
2012-03-05 16:58 ` Timur Tabi
2012-03-05 16:58 ` Timur Tabi
2012-03-05 17:32 ` Mark Brown
2012-03-05 17:32 ` Mark Brown
2012-03-04 23:34 ` Tabi Timur-B04825
2012-03-04 23:34 ` Tabi Timur-B04825
2012-03-05 8:07 ` Shawn Guo
2012-03-05 8:07 ` Shawn Guo
2012-03-04 13:32 ` [PATCH 00/20] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Mark Brown
2012-03-04 13:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306201153.GF19635@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.