From: Andrea Arcangeli <aarcange@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Bob Liu <lliubbo@gmail.com>,
akpm@linux-foundation.org, rientjes@google.com,
kamezawa.hiroyu@jp.fujitsu.com, minchan.kim@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] ksm: clean up page_trans_compound_anon_split
Date: Wed, 7 Mar 2012 01:26:16 +0100 [thread overview]
Message-ID: <20120307002616.GP13462@redhat.com> (raw)
In-Reply-To: <20120307001148.GO13462@redhat.com>
On Wed, Mar 07, 2012 at 01:11:48AM +0100, Andrea Arcangeli wrote:
> (the function was invoked only on compound pages in the first place).
BTW, most certainly I did at some point this change:
- if (page_trans_compound_anon_split(page))
+ if (PageTransCompound(page) && page_trans_compound_anon_split(page))
Before doing this change, the "cleaned up" version would have been
broken.
The original idea was to return 1 only in real error condition when a
THP splitting failure was encountered. So it had to be neutral and not
error out if split_huge_page wasn't needed.
In short the cleaned up version of page_trans_compound_anon_split is a
bit less generic but it being a static and only used here I don't mind
too much.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-07 0:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:32 [PATCH 1/2] ksm: clean up page_trans_compound_anon_split Bob Liu
2012-03-01 9:32 ` [PATCH 2/2] ksm: cleanup: introduce ksm_check_mm() Bob Liu
2012-03-01 20:51 ` Andrew Morton
2012-03-02 2:30 ` Bob Liu
2012-03-06 23:42 ` Hugh Dickins
2012-03-06 23:28 ` [PATCH 1/2] ksm: clean up page_trans_compound_anon_split Hugh Dickins
2012-03-07 0:11 ` Andrea Arcangeli
2012-03-07 0:26 ` Andrea Arcangeli [this message]
2012-03-07 10:39 ` Bob Liu
2012-03-07 15:47 ` Andrea Arcangeli
2012-03-07 1:21 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307002616.GP13462@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.