All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: auparse, stdin, and AUPARSE_CB_EVENT_READY
Date: Wed, 7 Mar 2012 12:19:02 -0500	[thread overview]
Message-ID: <201203071219.02278.sgrubb@redhat.com> (raw)
In-Reply-To: <4F5791D2.8080201@mozilla.com>

On Wednesday, March 07, 2012 11:50:26 AM Guillaume Destuynder wrote:
> Below patch "fixes" it. The problem is that if you have a node name
> included in the message, and that it's a long hostname, it's just not
> copying a long enough string, and it will fail to parse the message
> serial. When the serial is incorrect, auparse will fail to group them
> and notify with AUPARSE_CB_EVENT_READY as a consequence.
> 
> Now, I write this "fixes" it because if you have a really, really long
> hostname, it will fail in the same manner.

Yes. It looks like we support names up to 255 bytes. So, the "fix" needs more to 
it. This also affects ausearch/report as well. Since this points directly to the 
problem, the real fix should be straight forward.

> Or just do away with strtok and avoid duping strings.

Sure, that's the long term plan. 

-Steve

  reply	other threads:[~2012-03-07 17:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06  0:23 auparse, stdin, and AUPARSE_CB_EVENT_READY dump
2012-03-07 16:50 ` Guillaume Destuynder
2012-03-07 17:19   ` Steve Grubb [this message]
2012-03-07 17:48 ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203071219.02278.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.