From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Rainer Koenig <Rainer.Koenig@ts.fujitsu.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] Eject button handling in quickstart driver
Date: Wed, 7 Mar 2012 15:21:10 +0000 [thread overview]
Message-ID: <20120307152110.GA10945@srcf.ucam.org> (raw)
In-Reply-To: <4F576A87.1080401@ts.fujitsu.com>
On Wed, Mar 07, 2012 at 03:02:47PM +0100, Rainer Koenig wrote:
> + if (strncasecmp(quickstart->btn->name, "ODDE", 4) == 0) {
> + /* ODDE is Optical Disc Drive Eject */
> + quickstart_data.pressed = quickstart->btn;
> + }
This is wrong. Since the GHID method returns an arbitrary
vendor-specific value, you should just make sure that there's
appropriate keymap remapping support and then provide a udev fragment
that does the appropriate GHID->keycode assignment. Also, you really do
need to report this as KEY_CDEJECT - it's not acceptable to require an
acpid script.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-03-07 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 14:02 [PATCH] Eject button handling in quickstart driver Rainer Koenig
2012-03-07 14:31 ` Corentin Chary
2012-03-07 15:21 ` Matthew Garrett [this message]
2012-03-08 13:16 ` Rainer Koenig
2012-03-08 13:56 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307152110.GA10945@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Rainer.Koenig@ts.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.