From: Tony Lindgren <tony@atomide.com>
To: Russ Dill <Russ.Dill@ti.com>
Cc: Kevin Hilman <khilman@ti.com>,
balbi@ti.com, Matt Porter <mporter@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Wed, 7 Mar 2012 09:21:16 -0800 [thread overview]
Message-ID: <20120307172116.GF12083@atomide.com> (raw)
In-Reply-To: <CA+Bv8XaJqL1L8F-n6skY7dHn1XAdDLRKaRjw0deLeoQ5Ao0Fhg@mail.gmail.com>
* Russ Dill <Russ.Dill@ti.com> [120307 07:28]:
> On Mon, Mar 5, 2012 at 12:18 PM, Kevin Hilman <khilman@ti.com> wrote:
> >
> > In either case $SUBJECT patch is already in Tony's fixes queue, so if it
> > is going be merged, then my fix above is needed also to not break
> > Overo and any other platform that has more than one smsc911x instance.
> >
> > Kevin
>
>
> Have you tested this fix? The only regulator consumer supply would be:
>
> static struct regulator_consumer_supply gpmc_smsc911x_supply[] = {
> REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
> REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
> };
>
> I don't think the second smsc911x on the Overo, "smsc911x.1", would
> find it due to the dev_id.
Hmm yeah sounds like there's some further changes needed. Dropping
the second version from fixes until we have somebody reply with
tested-by using two smsc911x instances.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Wed, 7 Mar 2012 09:21:16 -0800 [thread overview]
Message-ID: <20120307172116.GF12083@atomide.com> (raw)
In-Reply-To: <CA+Bv8XaJqL1L8F-n6skY7dHn1XAdDLRKaRjw0deLeoQ5Ao0Fhg@mail.gmail.com>
* Russ Dill <Russ.Dill@ti.com> [120307 07:28]:
> On Mon, Mar 5, 2012 at 12:18 PM, Kevin Hilman <khilman@ti.com> wrote:
> >
> > In either case $SUBJECT patch is already in Tony's fixes queue, so if it
> > is going be merged, then my fix above is needed also to not break
> > Overo and any other platform that has more than one smsc911x instance.
> >
> > Kevin
>
>
> Have you tested this fix? The only regulator consumer supply would be:
>
> static struct regulator_consumer_supply gpmc_smsc911x_supply[] = {
> REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
> REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
> };
>
> I don't think the second smsc911x on the Overo, "smsc911x.1", would
> find it due to the dev_id.
Hmm yeah sounds like there's some further changes needed. Dropping
the second version from fixes until we have somebody reply with
tested-by using two smsc911x instances.
Regards,
Tony
next prev parent reply other threads:[~2012-03-07 17:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 14:16 [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators Matt Porter
2012-02-23 14:16 ` Matt Porter
2012-03-01 20:36 ` Kevin Hilman
2012-03-01 20:36 ` Kevin Hilman
2012-03-01 20:45 ` Felipe Balbi
2012-03-01 20:45 ` Felipe Balbi
2012-03-05 18:18 ` Kevin Hilman
2012-03-05 18:18 ` Kevin Hilman
2012-03-07 16:00 ` Russ Dill
2012-03-07 16:00 ` Russ Dill
2012-03-07 17:21 ` Tony Lindgren [this message]
2012-03-07 17:21 ` Tony Lindgren
2012-03-07 19:36 ` Kevin Hilman
2012-03-07 19:36 ` Kevin Hilman
2012-03-08 21:08 ` Tony Lindgren
2012-03-08 21:08 ` Tony Lindgren
2012-03-08 21:26 ` Kevin Hilman
2012-03-08 21:26 ` Kevin Hilman
2012-03-09 0:06 ` Tony Lindgren
2012-03-09 0:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307172116.GF12083@atomide.com \
--to=tony@atomide.com \
--cc=Russ.Dill@ti.com \
--cc=balbi@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mporter@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.