From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: kys@microsoft.com, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name
Date: Wed, 7 Mar 2012 11:22:04 -0800 [thread overview]
Message-ID: <20120307192204.GA9163@kroah.com> (raw)
In-Reply-To: <1331147131-6660-1-git-send-email-haiyangz@microsoft.com>
On Wed, Mar 07, 2012 at 11:05:31AM -0800, Haiyang Zhang wrote:
> From: Olaf Hering <olaf@aepfle.de>
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 0ae7a1a..53d1ee5 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -40,6 +40,8 @@
>
> #include "hyperv_net.h"
>
> +#define MODULE_NAME "hv_netvsc"
No, please use the built-in macro for this and don't define your own,
that's totally redundant.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Olaf Hering <olaf@aepfle.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, davem@davemloft.net
Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name
Date: Wed, 7 Mar 2012 11:22:04 -0800 [thread overview]
Message-ID: <20120307192204.GA9163@kroah.com> (raw)
In-Reply-To: <1331147131-6660-1-git-send-email-haiyangz@microsoft.com>
On Wed, Mar 07, 2012 at 11:05:31AM -0800, Haiyang Zhang wrote:
> From: Olaf Hering <olaf@aepfle.de>
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
> drivers/net/hyperv/netvsc_drv.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 0ae7a1a..53d1ee5 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -40,6 +40,8 @@
>
> #include "hyperv_net.h"
>
> +#define MODULE_NAME "hv_netvsc"
No, please use the built-in macro for this and don't define your own,
that's totally redundant.
greg k-h
next prev parent reply other threads:[~2012-03-07 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 19:05 [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name Haiyang Zhang
2012-03-07 19:22 ` Greg KH [this message]
2012-03-07 19:22 ` Greg KH
2012-03-07 19:57 ` Haiyang Zhang
2012-03-07 20:17 ` Olaf Hering
2012-03-07 20:49 ` Greg KH
2012-03-07 20:49 ` Greg KH
2012-03-08 6:16 ` Olaf Hering
2012-03-08 15:52 ` Greg KH
2012-03-08 15:52 ` Greg KH
2012-03-08 16:12 ` Olaf Hering
2012-03-08 17:42 ` Greg KH
2012-03-08 18:38 ` Olaf Hering
2012-03-08 18:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307192204.GA9163@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.