From: Arun Sharma <asharma@fb.com>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Namhyung Kim <namhyung.kim@lge.com>,
Tom Zanussi <tzanussi@gmail.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE
Date: Wed, 7 Mar 2012 15:13:15 -0800 [thread overview]
Message-ID: <20120307231315.GA24736@dev3310.snc6.facebook.com> (raw)
In-Reply-To: <1331160079-13821-3-git-send-email-asharma@fb.com>
Further testing showed one more bad memory reference when using
sort inclusive. Fixed by the patch below.
commit 799f80b6e8168d4813de094f2327367d6d226a8c
Author: Arun Sharma <asharma@fb.com>
Date: Wed Mar 7 15:05:00 2012 -0800
perf: fix some bad memory references in tui
Check for he->ms.sym since that's what we're dereferencing
Signed-off-by: Arun Sharma <asharma@fb.com>
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index b9d0fb2..d4e0ec5 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -86,7 +86,7 @@ static int perf_evsel__add_hist_entry(struct perf_evsel *evsel,
* so we don't allocated the extra space needed because the stdio
* code will not use it.
*/
- if (al->sym != NULL && use_browser > 0) {
+ if (he->ms.sym != NULL && use_browser > 0) {
struct annotation *notes = symbol__annotation(he->ms.sym);
assert(evsel != NULL);
next prev parent reply other threads:[~2012-03-07 23:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 22:41 [PATCH 0/2] perf: add sort by inclusive time functionality (v2) Arun Sharma
2012-03-07 22:41 ` [PATCH 1/2] perf: refactor add_hist_entry() code paths Arun Sharma
2012-03-07 22:41 ` [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE Arun Sharma
2012-03-07 23:13 ` Arun Sharma [this message]
2012-03-08 7:22 ` Ingo Molnar
2012-03-12 19:35 ` Arun Sharma
2012-03-12 19:35 ` Arun Sharma
2012-03-08 15:39 ` Frederic Weisbecker
2012-03-08 18:22 ` Arun Sharma
2012-03-13 13:44 ` Frederic Weisbecker
2012-03-08 7:29 ` [PATCH 0/2] perf: add sort by inclusive time functionality (v2) Ingo Molnar
2012-03-08 15:31 ` Frederic Weisbecker
2012-03-08 18:49 ` Arun Sharma
2012-03-08 18:49 ` Arun Sharma
2012-03-12 7:15 ` Namhyung Kim
2012-03-12 18:05 ` Arun Sharma
2012-03-12 18:05 ` Arun Sharma
2012-03-13 1:11 ` Namhyung Kim
2012-03-12 7:43 ` Namhyung Kim
2012-03-12 18:21 ` Arun Sharma
2012-03-12 18:21 ` Arun Sharma
2012-03-12 19:58 ` Arun Sharma
2012-03-12 19:58 ` Arun Sharma
2012-03-13 1:36 ` Namhyung Kim
2012-03-15 14:50 ` Frederic Weisbecker
2012-03-15 17:41 ` Arun Sharma
2012-03-15 17:41 ` Arun Sharma
2012-03-13 1:16 ` Namhyung Kim
2012-03-13 18:45 ` Arun Sharma
2012-03-13 18:45 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307231315.GA24736@dev3310.snc6.facebook.com \
--to=asharma@fb.com \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.