All of lore.kernel.org
 help / color / mirror / Atom feed
From: "majianpeng" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: md:Fix a bug in function badblocks_show().
Date: Thu, 8 Mar 2012 14:46:52 +0800	[thread overview]
Message-ID: <201203081446488121330@gmail.com> (raw)

From 58d2ba381eee4b732fca99a7311b1dcf589f57c3 Mon Sep 17 00:00:00 2001
From: majianpeng <majianpeng@gmail.com>
Date: Thu, 8 Mar 2012 14:37:00 +0800
Subject: [PATCH] md:Fix a bug in function badblocks_show().

If unack==0, it will show all bad blocks include unacknowledged-bad-blocks.

Signed-off-by: majianpeng <majianpeng@gmail.com>
---
 drivers/md/md.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index ce88755..3f1b6e5 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8091,7 +8091,7 @@ retry:
 		int ack = BB_ACK(p[i]);
 		i++;
 
-		if (unack && ack)
+		if ((unack ^ ack) == 0)
 			continue;
 
 		len += snprintf(page+len, PAGE_SIZE-len, "%llu %u\n",
-- 
1.7.5.4

 				
--------------
majianpeng
2012-03-08


             reply	other threads:[~2012-03-08  6:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  6:46 majianpeng [this message]
2012-03-14  1:32 ` md:Fix a bug in function badblocks_show() NeilBrown
2012-06-12  9:04   ` kedacomkernel
2012-06-27  3:01     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203081446488121330@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.