From: Greg KH <greg@kroah.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name
Date: Thu, 8 Mar 2012 07:52:19 -0800 [thread overview]
Message-ID: <20120308155219.GC5907@kroah.com> (raw)
In-Reply-To: <20120308061615.GA25237@aepfle.de>
On Thu, Mar 08, 2012 at 07:16:16AM +0100, Olaf Hering wrote:
> On Wed, Mar 07, Greg KH wrote:
>
> > On Wed, Mar 07, 2012 at 09:17:46PM +0100, Olaf Hering wrote:
> > > On Wed, Mar 07, Haiyang Zhang wrote:
> > >
> > >
> > > > @@ -482,7 +484,7 @@ MODULE_DEVICE_TABLE(vmbus, id_table);
> > > >
> > > > /* The one and only one */
> > > > static struct hv_driver netvsc_drv = {
> > > > - .name = "netvsc",
> > > > + .name = MODULE_NAME,
> > >
> > > It would be nice if this could be applied to 3.3.
> > > hv_storvsc and hid-hyperv already use the same naming, this patch was
> > > send last year already but was not applied for some reason.
> >
> > What userspace tools depend on this that requires it to be in 3.3?
>
> It represents the module names, at least for pci and other bus types.
Yes, but no one should care what the name of the module is.
> hwinfo uses it to recognize a network interface (storage in case of
> hv_storvsc).
That tool should report the real module name, not rely on the name to
match based on the structure, if you really care about the real module
name.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: devel@linuxdriverproject.org, netdev@vger.kernel.org,
Haiyang Zhang <haiyangz@microsoft.com>,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name
Date: Thu, 8 Mar 2012 07:52:19 -0800 [thread overview]
Message-ID: <20120308155219.GC5907@kroah.com> (raw)
In-Reply-To: <20120308061615.GA25237@aepfle.de>
On Thu, Mar 08, 2012 at 07:16:16AM +0100, Olaf Hering wrote:
> On Wed, Mar 07, Greg KH wrote:
>
> > On Wed, Mar 07, 2012 at 09:17:46PM +0100, Olaf Hering wrote:
> > > On Wed, Mar 07, Haiyang Zhang wrote:
> > >
> > >
> > > > @@ -482,7 +484,7 @@ MODULE_DEVICE_TABLE(vmbus, id_table);
> > > >
> > > > /* The one and only one */
> > > > static struct hv_driver netvsc_drv = {
> > > > - .name = "netvsc",
> > > > + .name = MODULE_NAME,
> > >
> > > It would be nice if this could be applied to 3.3.
> > > hv_storvsc and hid-hyperv already use the same naming, this patch was
> > > send last year already but was not applied for some reason.
> >
> > What userspace tools depend on this that requires it to be in 3.3?
>
> It represents the module names, at least for pci and other bus types.
Yes, but no one should care what the name of the module is.
> hwinfo uses it to recognize a network interface (storage in case of
> hv_storvsc).
That tool should report the real module name, not rely on the name to
match based on the structure, if you really care about the real module
name.
greg k-h
next prev parent reply other threads:[~2012-03-08 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 19:05 [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name Haiyang Zhang
2012-03-07 19:22 ` Greg KH
2012-03-07 19:22 ` Greg KH
2012-03-07 19:57 ` Haiyang Zhang
2012-03-07 20:17 ` Olaf Hering
2012-03-07 20:49 ` Greg KH
2012-03-07 20:49 ` Greg KH
2012-03-08 6:16 ` Olaf Hering
2012-03-08 15:52 ` Greg KH [this message]
2012-03-08 15:52 ` Greg KH
2012-03-08 16:12 ` Olaf Hering
2012-03-08 17:42 ` Greg KH
2012-03-08 18:38 ` Olaf Hering
2012-03-08 18:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308155219.GC5907@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.