From: Greg KH <gregkh@linuxfoundation.org>
To: Colin Cross <ccross@android.com>
Cc: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 05/11] android: ram_console: split out persistent ram
Date: Thu, 8 Mar 2012 09:33:06 -0800 [thread overview]
Message-ID: <20120308173306.GA4456@kroah.com> (raw)
In-Reply-To: <CAMbhsRRDmH47r_s_-H+tnZ62c9HdE3VqeTn5Qp4kwe5EOjJ4jw@mail.gmail.com>
On Wed, Mar 07, 2012 at 07:06:42PM -0800, Colin Cross wrote:
> On Wed, Mar 7, 2012 at 6:42 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Mar 07, 2012 at 05:34:32PM -0800, John Stultz wrote:
> >> From: Colin Cross <ccross@android.com>
> >>
> >> Split ram_console into two halves.
> >>
> >> persistent_ram is a set of apis that handle a block of memory
> >> that does not get erased across a reboot. It provides functions
> >> to fill it as a single buffer or a ring buffer, and to extract
> >> the old data after a reboot. It handles ecc on the data to
> >> correct bit errors introduced during reboot.
> >
> > That's a nice idea, but why are you rolling your own interface here and
> > not using the built-in one that the kernel already provides? Is there
> > something lacking with what we have today that requires you to create
> > something different? If so, why not just modify the existing interface
> > to make it work for you, that way the tools already created will work
> > automatically, and you will not have problems later ripping this out and
> > porting it to the in-kernel api.
>
> What interface are you referring to, pstore?
Yes.
> As I explained in the email John quoted to you,
Wait, what email? Did I miss a response here? Have a message-id: I can
search for?
> pstore would be a client of this, and ramconsole could be moved on top
> of pstore.
Ok, as long as that is the end goal, that's fine, it was not obvious
that this was the case at all, hence my confusion.
> This patch is just a refactoring that splits ramconsole and the
> persistent storage apart without significantly changing the api
> between them, and only makes it easier to insert pstore between them.
That's good to hear, I'll go queue them up then, thanks for clearing
this up.
greg k-h
next prev parent reply other threads:[~2012-03-08 17:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 1:34 [PATCH 00/11] staging: Android updates (take 2) John Stultz
2012-03-08 1:34 ` [PATCH 01/11] android: ram_console: set CON_ANYTIME console flag John Stultz
2012-03-08 1:34 ` [PATCH 02/11] android: ram_console: move footer strings John Stultz
2012-03-08 1:34 ` [PATCH 03/11] android: ram_console: drop early buffer support John Stultz
2012-03-08 1:34 ` [PATCH 04/11] android: ram_console: drop verbose ram_console support John Stultz
2012-03-08 1:34 ` [PATCH 05/11] android: ram_console: split out persistent ram John Stultz
2012-03-08 2:42 ` Greg KH
2012-03-08 3:06 ` Colin Cross
2012-03-08 17:33 ` Greg KH [this message]
2012-03-08 18:24 ` Colin Cross
2012-03-08 18:39 ` Greg KH
2012-03-08 3:59 ` John Stultz
2012-03-08 17:33 ` Greg KH
2012-03-08 1:34 ` [PATCH 06/11] android: persistent_ram: refactor ecc support John Stultz
2012-03-08 1:34 ` [PATCH 07/11] android: persistent_ram: handle reserving and mapping memory John Stultz
2012-03-08 1:34 ` [PATCH 08/11] android: persistent_ram: make persistent_ram_write atomic John Stultz
2012-03-08 1:34 ` [PATCH 09/11] android: persistent_ram: add notrace to persistent_ram_write John Stultz
2012-03-08 1:34 ` [PATCH 10/11] android: staging: ram_console: fix crash in ram_console_late_init John Stultz
2012-03-08 1:34 ` [PATCH 11/11] android: ram_console: honor dmesg_restrict John Stultz
2012-03-08 2:42 ` [PATCH 00/11] staging: Android updates (take 2) Greg KH
2012-03-08 9:08 ` [PATCH] staging: ram_console: Fix section mismatches Stephen Boyd
2012-03-08 17:56 ` Greg KH
2012-03-08 18:12 ` Stephen Boyd
2012-03-08 18:23 ` Greg KH
2012-03-08 18:34 ` Stephen Boyd
2012-03-08 18:43 ` Greg KH
2012-03-08 19:33 ` Stephen Boyd
2012-03-08 19:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308173306.GA4456@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ccross@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.