From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Russ Dill <Russ.Dill@ti.com>,
balbi@ti.com, Matt Porter <mporter@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Thu, 8 Mar 2012 13:08:26 -0800 [thread overview]
Message-ID: <20120308210825.GY12083@atomide.com> (raw)
In-Reply-To: <87sjhkjj8m.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [120307 11:05]:
> >
> > I don't think the second smsc911x on the Overo, "smsc911x.1", would
> > find it due to the dev_id.
>
> It's not about finding the second regulator. As stated in the
> changelog, it's about the duplicate attempt to register the exact same
> platform_device.
>
> Duplicate attempts to register the exact same platform_device cause
> kobject to panic and give up[1]. So, any platform that calls
> gpmc_smsc911x_init() twice (Overo and T35 in mainline) will panic on
> boot.
>
> This patch fixes those platforms so they can boot.
Yeah but I guess the second smsc911x instance still would not work,
or am I missing something?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Thu, 8 Mar 2012 13:08:26 -0800 [thread overview]
Message-ID: <20120308210825.GY12083@atomide.com> (raw)
In-Reply-To: <87sjhkjj8m.fsf@ti.com>
* Kevin Hilman <khilman@ti.com> [120307 11:05]:
> >
> > I don't think the second smsc911x on the Overo, "smsc911x.1", would
> > find it due to the dev_id.
>
> It's not about finding the second regulator. As stated in the
> changelog, it's about the duplicate attempt to register the exact same
> platform_device.
>
> Duplicate attempts to register the exact same platform_device cause
> kobject to panic and give up[1]. So, any platform that calls
> gpmc_smsc911x_init() twice (Overo and T35 in mainline) will panic on
> boot.
>
> This patch fixes those platforms so they can boot.
Yeah but I guess the second smsc911x instance still would not work,
or am I missing something?
Regards,
Tony
next prev parent reply other threads:[~2012-03-08 21:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 14:16 [PATCH v3] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators Matt Porter
2012-02-23 14:16 ` Matt Porter
2012-03-01 20:36 ` Kevin Hilman
2012-03-01 20:36 ` Kevin Hilman
2012-03-01 20:45 ` Felipe Balbi
2012-03-01 20:45 ` Felipe Balbi
2012-03-05 18:18 ` Kevin Hilman
2012-03-05 18:18 ` Kevin Hilman
2012-03-07 16:00 ` Russ Dill
2012-03-07 16:00 ` Russ Dill
2012-03-07 17:21 ` Tony Lindgren
2012-03-07 17:21 ` Tony Lindgren
2012-03-07 19:36 ` Kevin Hilman
2012-03-07 19:36 ` Kevin Hilman
2012-03-08 21:08 ` Tony Lindgren [this message]
2012-03-08 21:08 ` Tony Lindgren
2012-03-08 21:26 ` Kevin Hilman
2012-03-08 21:26 ` Kevin Hilman
2012-03-09 0:06 ` Tony Lindgren
2012-03-09 0:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308210825.GY12083@atomide.com \
--to=tony@atomide.com \
--cc=Russ.Dill@ti.com \
--cc=balbi@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mporter@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.