From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH 1/3] ASoC: omap-mcbsp: fix snd_pcm_hw_rule_add arguments
Date: Fri, 9 Mar 2012 12:19:06 +0000 [thread overview]
Message-ID: <20120309121906.GI3273@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331248757-3408-2-git-send-email-notasas@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 367 bytes --]
On Fri, Mar 09, 2012 at 01:19:15AM +0200, Grazvydas Ignotas wrote:
> We are setting SNDRV_PCM_HW_PARAM_BUFFER_SIZE based on
> SNDRV_PCM_HW_PARAM_CHANNELS, not vice versa. This bug didn't
> have much impact because the rules are evaluated multiple times
> by the core, and intended value got set eventually.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-09 12:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 23:19 [PATCH 0/3] ASoC: omap-mcbsp: fixes for some underflow problems Grazvydas Ignotas
2012-03-08 23:19 ` [PATCH 1/3] ASoC: omap-mcbsp: fix snd_pcm_hw_rule_add arguments Grazvydas Ignotas
2012-03-09 10:08 ` Peter Ujfalusi
2012-03-09 10:45 ` Grazvydas Ignotas
2012-03-09 12:01 ` Peter Ujfalusi
2012-03-09 12:02 ` Peter Ujfalusi
2012-03-09 12:19 ` Mark Brown [this message]
2012-03-08 23:19 ` [PATCH 2/3] ASoC: omap-mcbsp: place size constrain on period, not buffer Grazvydas Ignotas
2012-03-09 12:19 ` Mark Brown
2012-03-08 23:19 ` [PATCH 3/3] ASoC: omap-mcbsp: make minimum period size larger than FIFO Grazvydas Ignotas
2012-03-09 12:20 ` Mark Brown
2012-03-09 12:42 ` Peter Ujfalusi
2012-03-09 13:25 ` Grazvydas Ignotas
2012-03-09 13:42 ` Peter Ujfalusi
2012-03-09 21:07 ` Grazvydas Ignotas
2012-03-11 17:39 ` Jarkko Nikula
2012-03-12 12:05 ` Grazvydas Ignotas
2012-03-12 12:15 ` Mark Brown
2012-03-12 12:41 ` Peter Ujfalusi
2012-03-12 14:06 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309121906.GI3273@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lrg@ti.com \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.