From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 11 Mar 2012 03:35:45 -0400 Subject: [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c In-Reply-To: References: <1329787975-6695-1-git-send-email-sjg@chromium.org> <201203061120.44727.vapier@gentoo.org> Message-ID: <201203110335.47070.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 07 March 2012 00:50:15 Graeme Russ wrote: > On Wed, Mar 7, 2012 at 3:20 AM, Mike Frysinger wrote: > > On Tuesday 06 March 2012 01:34:24 Simon Glass wrote: > >> On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote: > >> > On Monday 20 February 2012 20:32:47 Simon Glass wrote: > >> >> These basic functions are needed by relocation. To avoid bringing in > >> >> all string.c functions (and the resulting code bloat for > >> >> architectures where -ffunction-sections is not used), move these > >> >> into their own file. > >> > > >> > seems like fixing -f{data,function}-sections would be a more useful > >> > goal. i don't know why arm doesn't support this today ... it's fairly > >> > easy to do. > >> > >> I did enable it for Tegra at one point with no ill effects except for > >> breaking warmboot, which relied on function ordering. I notice the > >> no-toplevel-reorder flag on x86 but not with ARM. But I assumed there > >> must be some reason it is not used and thought this patch safer, since > >> it is just a minor tweak on a series that has has some review. > > > > if we keep assuming that, then it'll never get fixed, and we'll sit on a > > steady stream of "small safe patches". plus, fixing this yields general > > improvements in anti-bloat for everyone. > > > > function ordering sounds like something that should be imposed at the > > linker level ... for Blackfin, all i had to care about was the entry > > point was at the start of the .text, although warmbooting is fairly low > > level magic, and i handle that in the SPL-like core. > > Can't the entry point be forced to be at the start of the u-boot image by > putting that function in a dedicated section and specifying that section > as the first in the linker script? yes ... that's what Blackfin does: ... ENTRY(_start) SECTIONS { .text.pre : { arch/blackfin/cpu/start.o (.text .text.*) ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: