From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH 1/4] e2fsck: Discard only unused parts of inode table
Date: Sun, 11 Mar 2012 15:27:05 -0400 [thread overview]
Message-ID: <20120311192705.GE1048@thunk.org> (raw)
In-Reply-To: <1330933776-2696-1-git-send-email-lczerner@redhat.com>
On Mon, Mar 05, 2012 at 08:49:33AM +0100, Lukas Czerner wrote:
> @@ -435,6 +481,7 @@ static void check_inode_bitmaps(e2fsck_t ctx)
> int skip_group = 0;
> int redo_flag = 0;
> io_manager manager = ctx->fs->io->manager;
> + unsigned long long first_free = fs->super->s_inodes_per_group + 1;
This doesn't need to be an unsigned long long; an "int" will do just
as well.
> + /*
> + * If the last inode is free, we can discard it as well.
> + */
> + if (inodes >= first_free)
> + e2fsck_discard_inodes(ctx, group, first_free,
> + inodes - first_free + 1);
There's no guarantee the last inode is free here. This needs to read:
if (!bitmap && inodes >= first_free)
I'll fix this up in my version of the patches.
- Ted
next prev parent reply other threads:[~2012-03-11 19:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 7:49 [PATCH 1/4] e2fsck: Discard only unused parts of inode table Lukas Czerner
2012-03-05 7:49 ` [PATCH 2/4] e2fsck: Do not forget to discard last block group Lukas Czerner
2012-03-05 19:29 ` Eric Sandeen
2012-03-11 19:18 ` Ted Ts'o
2012-03-11 19:33 ` [PATCH 1/3] e2fsck: remove last argument from e2fsck_discard_blocks() Theodore Ts'o
2012-03-11 19:33 ` [PATCH 2/3] e2fsck: do not forget to discard last block group Theodore Ts'o
2012-03-12 7:31 ` Lukas Czerner
2012-03-11 19:33 ` [PATCH 3/3] e2fsck: optimize CPU usage in check_{block,inode}_bitmaps() Theodore Ts'o
2012-03-12 7:44 ` Lukas Czerner
2012-03-12 7:30 ` [PATCH 1/3] e2fsck: remove last argument from e2fsck_discard_blocks() Lukas Czerner
2012-03-05 7:49 ` [PATCH 3/4] e2fsck: Do not discard when in read only mode Lukas Czerner
2012-03-05 19:33 ` Eric Sandeen
2012-03-11 19:35 ` Ted Ts'o
2012-03-05 7:49 ` [PATCH 4/4] e2fsck: Do not discard itable if discard doen't zero data Lukas Czerner
2012-03-05 19:46 ` Eric Sandeen
2012-03-11 19:39 ` Ted Ts'o
2012-03-05 17:45 ` [PATCH 1/4] e2fsck: Discard only unused parts of inode table Eric Sandeen
2012-03-05 18:43 ` Lukas Czerner
2012-03-05 19:01 ` Eric Sandeen
2012-03-11 19:27 ` Ted Ts'o [this message]
2012-03-12 7:26 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311192705.GE1048@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.