All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, javier.martin@vista-silicon.com,
	kernel@pengutronix.de
Subject: Re: [PATCH] ASoC: mx27vis-aic32x4: Convert it to platform driver
Date: Sun, 11 Mar 2012 20:46:20 +0000	[thread overview]
Message-ID: <20120311204620.GD3171@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331496516-6578-1-git-send-email-festevam@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 331 bytes --]

On Sun, Mar 11, 2012 at 05:08:36PM -0300, Fabio Estevam wrote:

> +MODULE_ALIAS("mx27vis_aic32x4");

This needs to be platform:mx27vis_aic32x4 (though for style it'd be
probably better to rename to just mx27vis, since that's a specific board
rather than a generic class of them the CODEC name is redundant).

Otherwise looks good.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2012-03-11 20:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-11 20:08 [PATCH] ASoC: mx27vis-aic32x4: Convert it to platform driver Fabio Estevam
2012-03-11 20:46 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120311204620.GD3171@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=javier.martin@vista-silicon.com \
    --cc=kernel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.