From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: ath6kl-devel@qualcomm.com, linux-wireless@vger.kernel.org
Subject: [PATCH 1/4] ath6kl: fix regression in ath6kl_upload_board_file()
Date: Mon, 12 Mar 2012 13:22:54 +0200 [thread overview]
Message-ID: <20120312112254.23253.79934.stgit@x201> (raw)
In-Reply-To: <20120312112131.23253.74137.stgit@x201>
My patch 24fc32b3 ("ath6kl: add ath6kl_bmi_write_hi32()") caused a regression
in ath6kl_upload_board_file() and the board_address variable was not
properly initialised in some cases:
ath6kl/init.c:1068:6: warning: ‘board_address’ may be used uninitialized
in this function
Most likely this broke ar6004 support but I can't test that right now.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/init.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index 231675d..03cae14 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1078,8 +1078,9 @@ static int ath6kl_upload_board_file(struct ath6kl *ar)
* writing board data.
*/
if (ar->hw.board_addr != 0) {
+ board_address = ar->hw.board_addr;
ath6kl_bmi_write_hi32(ar, hi_board_data,
- ar->hw.board_addr);
+ board_address);
} else {
ath6kl_bmi_read_hi32(ar, hi_board_data, &board_address);
}
next prev parent reply other threads:[~2012-03-12 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 11:22 [PATCH 0/4] ath6kl: more checkpatch fixes Kalle Valo
2012-03-12 11:22 ` Kalle Valo [this message]
2012-03-12 11:23 ` [PATCH 2/4] ath6kl: replace strict_strtoul() with kstrtoul() Kalle Valo
2012-03-12 11:23 ` [PATCH 3/4] ath6kl: fix open parenthesis alignment in ath6kl_sdio_suspend() Kalle Valo
2012-03-12 11:23 ` [PATCH 4/4] ath6kl: use max_t() in ath6kl_cfg80211_connect() Kalle Valo
2012-03-13 12:23 ` [PATCH 0/4] ath6kl: more checkpatch fixes Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312112254.23253.79934.stgit@x201 \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.