Re: [PATCH] gpio: Add Altera GPIO driver

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Mon,  6 Feb 2012 18:59:02 +0100, Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org> wrote:
> This driver supports the Altera PIO core.
> 
> Signed-off-by: Thomas Chou <thomas-SDxUXYEhEBiCuPEqFHbRBg@public.gmane.org>
> Signed-off-by: Tobias Klauser <tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>
> ---
> This driver was submitted already about a year ago by Thomas, was
> adjusted by him according to some remarks made by Grant and was then
> included in the -mm tree [1] for some time but dropped again
> (couldn't find out when and why exactly).
> 
> [0] http://article.gmane.org/gmane.linux.drivers.devicetree/4231
> [1] http://article.gmane.org/gmane.linux.kernel.commits.mm/65119
> 
> So this is a new attempt towards getting this driver into mainline
> from the nios2 tree. The following changes have been made atop the
> version submitted by Thomas:
> 
> - Changed driver name to new naming convention
> - Usage of of_property_read_u32 in the probe function

This looks like a pretty generic memory-mapped gpio chip.  It should use the
gpio-generic infrastructure instead of open-coding all of the accessor hooks.

g.