From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
qemu-devel@nongnu.org, "Jan Kiszka" <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format
Date: Mon, 12 Mar 2012 16:22:06 -0500 [thread overview]
Message-ID: <20120312212206.GA19058@illuin> (raw)
In-Reply-To: <4F5E470A.5040909@codemonkey.ws>
On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote:
> On 03/12/2012 01:56 PM, Marc-André Lureau wrote:
> >On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori<anthony@codemonkey.ws> wrote:
> >>Why not just return the screendump through QMP?
> >
> >in base64, base85?
>
> I think Jan had patches for base64 blobs but I think it got tangled
> up in VMState related controversy.
Few months back, was planning on using them for qemu-ga. Looks like
they're not in yet, but FWIW qemu-ga has been using g_base64_encode() since
initial commit. I think Jan had some reservations about g_base64_decode()'s
error-handling, but that shouldn't be an issue in this particular case.
I agree on the QMP approach sounding a whole lot cleaner, especially
given that Juan recently did a some cleanups to remove non-migration
QEMUFile users:
3a230256e8418f5cc9761f36feb6952d7ca38d73
>
> Jan, am I correct?
>
> Regards,
>
> Anthony Liguori
>
>
next prev parent reply other threads:[~2012-03-12 21:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 13:11 [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 1/7] ppm_save: use QEMUFile Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 2/7] Allow a qemu_fopen_socket() to be opened for writing Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 3/7] Close socket when closing QEMUFile Marc-André Lureau
2012-03-13 6:09 ` Igor Mitsyanko
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 4/7] Allow saving screendump to a UNIX socket Marc-André Lureau
2012-03-12 17:07 ` Daniel P. Berrange
2012-03-13 8:15 ` Gerd Hoffmann
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 5/7] configure: split PNG support from vnc_png feature Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 6/7] Isolate color conversion from PPM handling Marc-André Lureau
2012-03-12 13:11 ` [Qemu-devel] [PATCH/RFC 7/7] Add PNG screendump Marc-André Lureau
2012-03-12 17:05 ` Daniel P. Berrange
2012-03-12 15:42 ` [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format Eric Blake
2012-03-12 19:29 ` Marc-André Lureau
2012-03-12 17:10 ` Daniel P. Berrange
2012-03-12 18:06 ` Stefan Hajnoczi
2012-03-12 19:27 ` Marc-André Lureau
2012-03-13 10:59 ` Stefan Hajnoczi
2012-03-13 11:14 ` Marc-André Lureau
2012-03-13 11:17 ` Stefan Hajnoczi
2012-03-13 13:17 ` Gerd Hoffmann
2012-03-14 9:42 ` Stefan Hajnoczi
2012-03-14 9:51 ` Gerd Hoffmann
2012-03-14 10:01 ` Stefan Hajnoczi
2012-03-14 13:13 ` Luiz Capitulino
2012-03-14 13:19 ` Alon Levy
2012-03-14 13:28 ` Eric Blake
2012-03-14 13:36 ` Luiz Capitulino
2012-03-14 11:42 ` Kevin Wolf
2012-03-14 13:14 ` Luiz Capitulino
2012-03-12 18:53 ` Anthony Liguori
2012-03-12 18:56 ` Marc-André Lureau
2012-03-12 18:57 ` Anthony Liguori
2012-03-12 21:22 ` Michael Roth [this message]
2012-03-13 10:12 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312212206.GA19058@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.