From: Johan Hedberg <johan.hedberg@gmail.com>
To: chen.ganir@ti.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 1/2] Add DeviceInformation GATT Client
Date: Tue, 13 Mar 2012 12:30:02 +0200 [thread overview]
Message-ID: <20120313103002.GA28153@x220> (raw)
In-Reply-To: <1331619860-10973-2-git-send-email-chen.ganir@ti.com>
Hi Chen,
On Tue, Mar 13, 2012, chen.ganir@ti.com wrote:
> +static int deviceinfo_init(void)
> +{
> + if (deviceinfo_manager_init() < 0) {
> + return -EIO;
> + }
> +
> + return 0;
> +}
Why not simply:
return deviceinfo_manager_init();
> +int deviceinfo_manager_init(void)
> +{
> + int ret;
> +
> + ret = btd_register_device_driver(&deviceinfo_device_driver);
> + if (ret < 0)
> + return ret;
> +
> + return 0;
> +}
Why not simply:
return btd_register_device_driver(&deviceinfo_device_driver);
Johan
next prev parent reply other threads:[~2012-03-13 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 6:24 [PATCH v4 0/2] DeviceInfo and BatteryService Clients chen.ganir
2012-03-13 6:24 ` [PATCH v4 1/2] Add DeviceInformation GATT Client chen.ganir
2012-03-13 10:30 ` Johan Hedberg [this message]
2012-03-13 6:24 ` [PATCH v4 2/2] Add Battery Service " chen.ganir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313103002.GA28153@x220 \
--to=johan.hedberg@gmail.com \
--cc=chen.ganir@ti.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.