From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Tue, 13 Mar 2012 10:46:15 +0000 Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (w83627ehf) Describe undocumented pwm attributes Message-Id: <20120313104615.GC31363@ericsson.com> List-Id: References: <1328806643-25371-1-git-send-email-guenter.roeck@ericsson.com> In-Reply-To: <1328806643-25371-1-git-send-email-guenter.roeck@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Tue, Mar 13, 2012 at 04:07:53AM -0400, Jean Delvare wrote: > On Thu, 9 Feb 2012 08:57:23 -0800, Guenter Roeck wrote: > > Add description of pwm[1-4]_start_output, pwm[1-4]_step_output, > > pwm[1-4]_stop_output, and pwm[1-4]_max_output attributes to driver > > documentation. > > Would be nice to have these standardized at some point... But meanwhile > I agree it's best described in the driver documentation file. > > > Signed-off-by: Guenter Roeck > > --- > > Documentation/hwmon/w83627ehf | 5 +++++ > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/hwmon/w83627ehf b/Documentation/hwmon/w83627ehf > > index 3f44dbd..ea75fe4 100644 > > --- a/Documentation/hwmon/w83627ehf > > +++ b/Documentation/hwmon/w83627ehf > > @@ -143,6 +143,11 @@ pwm[1-4]_min_output - minimum fan speed (range 1 - 255), when the temperature > > pwm[1-4]_stop_time - how many milliseconds [ms] must elapse to switch > > corresponding fan off. (when the temperature was below > > defined range). > > +pwm[1-4]_start_output-minimum fan speed (range 1 - 255) when spinning up > > +pwm[1-4]_step_output- rate of fan speed change (1 - 255) > > +pwm[1-4]_stop_output- minimum fan speed (range 1 - 255) when spinning down > > +pwm[1-4]_max_output - maximum fan speed (range 1 - 255), when the temperature > > + is above defined range. > > > > Note: last two functions are influenced by other control bits, not yet exported > > "last two" should probably become "last six". > > > by the driver, so a change might not have any effect. > > Other than this: > > Acked-by: Jean Delvare > Thanks, updated and applied. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors